Remove ws3 feature flag from APIs

Author: krlvi

crates/but-settings/assets/defaults.jsonc

@@ -18,10 +18,6 @@
 		"oauthClientId": "cd51880daa675d9e6452"
 	},
 	"featureFlags": {
-		// Enables the v3 design, as well as the purgatory mode (no uncommitted diff ownership assignments).
-		"v3": false,
-		/// Enable the usage of V3 workspace APIs.
-		"ws3": false,
 		/// Enable undo/redo support.
 		"undo": false,
 		/// Enable the usage of GitButler Acitions.

crates/but-settings/src/api.rs

@@ -15,7 +15,6 @@ pub struct TelemetryUpdate {
 #[serde(rename_all = "camelCase")]
 /// Update request for [`crate::app_settings::FeatureFlags`].
 pub struct FeatureFlagsUpdate {
-    pub ws3: Option<bool>,
     pub actions: Option<bool>,
     pub butbot: Option<bool>,
     pub rules: Option<bool>,
@@ -52,16 +51,12 @@ impl AppSettingsWithDiskSync {
     pub fn update_feature_flags(
         &self,
         FeatureFlagsUpdate {
-            ws3,
             actions,
             butbot,
             rules,
         }: FeatureFlagsUpdate,
     ) -> Result<()> {
         let mut settings = self.get_mut_enforce_save()?;
-        if let Some(ws3) = ws3 {
-            settings.feature_flags.ws3 = ws3;
-        }
         if let Some(actions) = actions {
             settings.feature_flags.actions = actions;
         }

crates/but-settings/src/app_settings.rs

@@ -23,9 +23,6 @@ pub struct GitHubOAuthAppSettings {
 #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub struct FeatureFlags {
-    /// Enable the usage of V3 workspace APIs.
-    #[serde(default = "default_true")]
-    pub ws3: bool,
     /// Enable undo/redo support.
     ///
     /// ### Progression for implementation
@@ -49,10 +46,6 @@ pub struct FeatureFlags {
     pub rules: bool,
 }
 
-fn default_true() -> bool {
-    true
-}
-
 #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub struct ExtraCsp {

crates/but-testing/src/command/mod.rs

@@ -336,13 +336,11 @@ pub mod stacks {
         description: Option<&str>,
         current_dir: &Path,
         use_json: bool,
-        ws3: bool,
     ) -> anyhow::Result<()> {
         let project = project_from_path(current_dir)?;
         // Enable v3 feature flags for the command context
         let app_settings = AppSettings {
             feature_flags: but_settings::app_settings::FeatureFlags {
-                ws3,
                 undo: false,
                 actions: false,
                 butbot: false,

crates/but-testing/src/main.rs

@@ -183,7 +183,6 @@ async fn main() -> Result<()> {
                 description.as_deref(),
                 &args.current_dir,
                 args.json,
-                args.v3,
             ),
             (None, Some(id)) => command::stacks::branches(*id, &args.current_dir, args.json),
             (None, None) => {

crates/but/src/mcp_internal/stack.rs

@@ -31,7 +31,6 @@ pub fn create_stack_with_branch(
     let app_settings = AppSettings {
         feature_flags: but_settings::app_settings::FeatureFlags {
             // Keep this off until it caught up at least.
-            ws3: false,
             undo: false,
             actions: false,
             butbot: false,

crates/but/src/mcp_internal/status.rs

@@ -11,7 +11,6 @@ pub fn project_status(project_dir: &Path) -> anyhow::Result<but_tools::workspace
     let app_settings = AppSettings {
         feature_flags: but_settings::app_settings::FeatureFlags {
             // Keep this off until it caught up at least.
-            ws3: false,
             undo: false,
             actions: false,
             butbot: false,