Move MatchLinesAboveTarget const out of FindMatchingLine

Author: jcansdale

src/GitHub.App/Services/NavigationService.cs

@@ -34,7 +34,7 @@ public IVsTextView NavigateToEquivalentPosition(IVsTextView sourceView, string t
 
             var fromLines = ReadLines(text1);
             var toLines = ReadLines(text2);
-            var matchingLine = FindMatchingLine(fromLines, toLines, line);
+            var matchingLine = FindMatchingLine(fromLines, toLines, line, matchLinesAbove: MatchLinesAboveTarget);
             if (matchingLine == -1)
             {
                 // If we can't match line use orignal as best guess.
@@ -68,11 +68,11 @@ public IVsTextView FindActiveView()
         /// <param name="toLines">The document we're navigating to.</param>
         /// <param name="line">The 0-based line we're navigating from.</param>
         /// <returns>The best matching line in <see cref="toLines"/></returns>
-        public int FindMatchingLine(IList<string> fromLines, IList<string> toLines, int line)
+        public int FindMatchingLine(IList<string> fromLines, IList<string> toLines, int line, int matchLinesAbove = 0)
         {
             var matchingLine = -1;
             var minMatchedLines = -1;
-            for (var offset = 0; offset <= MatchLinesAboveTarget; offset++)
+            for (var offset = 0; offset <= matchLinesAbove; offset++)
             {
                 var targetLine = line - offset;
                 if (targetLine < 0)

test/UnitTests/GitHub.App/Services/NavigationServiceTests.cs

@@ -39,7 +39,7 @@ public void FindNearestMatchingLine(IList<string> fromLines, IList<string> toLin
         {
             var target = CreateNavigationService();
 
-            var nearestLine = target.FindMatchingLine(fromLines, toLines, line);
+            var nearestLine = target.FindMatchingLine(fromLines, toLines, line, matchLinesAbove: 1);
 
             Assert.That(nearestLine, Is.EqualTo(matchingLine));
         }