Merge pull request #1997 from github/fixes/unit-tests

Various unit test fixes.

Author: grokys

.ncrunch/GitHub.App.UnitTests.v3.ncrunchproject

@@ -0,0 +1,5 @@
+<ProjectConfiguration>
+  <Settings>
+    <CopyReferencedAssembliesToWorkspace>True</CopyReferencedAssembliesToWorkspace>
+  </Settings>
+</ProjectConfiguration>

.ncrunch/GitHub.Exports.UnitTests.v3.ncrunchproject

@@ -0,0 +1,5 @@
+<ProjectConfiguration>
+  <Settings>
+    <CopyReferencedAssembliesToWorkspace>True</CopyReferencedAssembliesToWorkspace>
+  </Settings>
+</ProjectConfiguration>

GitHubVS.v3.ncrunchsolution

@@ -7,7 +7,7 @@
     <AdditionalFilesToIncludeForSolution>
       <Value>lib\**.*</Value>
     </AdditionalFilesToIncludeForSolution>
-    <AllowParallelTestExecution>False</AllowParallelTestExecution>
+    <AllowParallelTestExecution>True</AllowParallelTestExecution>
     <ProjectConfigStoragePathRelativeToSolutionDir>.ncrunch</ProjectConfigStoragePathRelativeToSolutionDir>
     <SolutionConfigured>True</SolutionConfigured>
   </Settings>

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

@@ -96,7 +96,7 @@ public PullRequestDetailViewModelDesigner()
 
             Files = new PullRequestFilesViewModelDesigner();
 
-            Checks = new PullRequestCheckViewModelDesigner[0];
+            Checks = Array.Empty<PullRequestCheckViewModelDesigner>();
         }
 
         public PullRequestDetailModel Model { get; }

src/GitHub.App/SampleData/PullRequestUserReviewsViewModelDesigner.cs

@@ -27,7 +27,7 @@ public PullRequestUserReviewsViewModelDesigner()
                 {
                     IsExpanded = true,
                     HasDetails = true,
-                    FileComments = new IPullRequestReviewFileCommentViewModel[0],
+                    FileComments = Array.Empty<IPullRequestReviewFileCommentViewModel>(),
                     StateDisplay = "approved",
                     Model = new PullRequestReviewModel
                     {

src/GitHub.App/Services/ModelService.cs

@@ -320,7 +320,7 @@ IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetUserRepositories(Repositor
                         log.Error(e,
                             "Retrieving {RepositoryType} user repositories failed because user is not stored in the cache",
                             repositoryType);
-                        return Observable.Return(new IRemoteRepositoryModel[] {});
+                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
                     });
         }
 
@@ -355,7 +355,7 @@ IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetOrganizationRepositories(s
                     {
                         log.Error(e, "Retrieveing {Organization} org repositories failed because user is not stored in the cache",
                             organization);
-                        return Observable.Return(new IRemoteRepositoryModel[] {});
+                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
                     });
         }
 

src/GitHub.App/Services/StandardUserErrors.cs

@@ -189,7 +189,7 @@ public static IObservable<RecoveryOptionResult> ShowUserErrorThatRequiresNavigat
 
             return exception.DisplayErrorMessage(
                 errorType,
-                new object[] { },
+                Array.Empty<object>(),
                 new[] { OpenBrowser("View Plans", account.Billing()), Cancel });
         }
 

src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs

@@ -182,7 +182,7 @@ public async Task InitializeAsync(IConnection connection)
 
             accounts = modelService.GetAccounts()
                 .ObserveOn(RxApp.MainThreadScheduler)
-                .ToProperty(this, vm => vm.Accounts, initialValue: new ReadOnlyCollection<IAccount>(new IAccount[] { }));
+                .ToProperty(this, vm => vm.Accounts, initialValue: new ReadOnlyCollection<IAccount>(Array.Empty<IAccount>()));
 
             this.WhenAny(x => x.Accounts, x => x.Value)
                 .Select(accts => accts?.FirstOrDefault())

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

@@ -51,7 +51,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
                 pullRequestCheckViewModel.DetailsUrl = !string.IsNullOrEmpty(model.TargetUrl) ? new Uri(model.TargetUrl) : null;
 
                 return pullRequestCheckViewModel;
-            }) ?? new PullRequestCheckViewModel[0];
+            }) ?? Array.Empty<PullRequestCheckViewModel>();
 
             var checks = pullRequest.CheckSuites?.SelectMany(model => model.CheckRuns)
                 .Select(model =>
@@ -97,7 +97,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
                     pullRequestCheckViewModel.DetailsUrl = new Uri(model.DetailsUrl);
 
                     return pullRequestCheckViewModel;
-                }) ?? new PullRequestCheckViewModel[0];
+                }) ?? Array.Empty<PullRequestCheckViewModel>();
 
             return statuses.Concat(checks).OrderBy(model => model.Title);
         }

src/GitHub.App/ViewModels/TeamExplorer/RepositoryPublishViewModel.cs

@@ -72,7 +72,7 @@ public RepositoryPublishViewModel(
                 .SelectMany(async c => (await modelServiceFactory.CreateAsync(c)).GetAccounts())
                 .Switch()
                 .ObserveOn(RxApp.MainThreadScheduler)
-                .ToProperty(this, x => x.Accounts, initialValue: new ReadOnlyCollection<IAccount>(new IAccount[] {}));
+                .ToProperty(this, x => x.Accounts, initialValue: new ReadOnlyCollection<IAccount>(Array.Empty<IAccount>()));
 
             this.WhenAny(x => x.Accounts, x => x.Value)
                 .WhereNotNull()