From 4e69c17b783fc2decca394f16b34b341355445ea Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@gmail.com>
Date: Tue, 27 Mar 2018 12:46:36 +0200
Subject: [PATCH] Add PR reviews metrics.

Adds two new metrics:

- `NumberOfPRReviewDiffViewInlineCommentStartReview`: incremented when the "Start Review" button is clicked from an inline comment
- `NumberOfPRReviewPosts`: incremented when a PR review is submitted
---
 src/GitHub.Exports/Models/UsageModel.cs        |  2 ++
 .../Services/PullRequestSessionService.cs      | 18 ++++++++++++++----
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/GitHub.Exports/Models/UsageModel.cs b/src/GitHub.Exports/Models/UsageModel.cs
index 216619e55f..325cd74e30 100644
--- a/src/GitHub.Exports/Models/UsageModel.cs
+++ b/src/GitHub.Exports/Models/UsageModel.cs
@@ -42,6 +42,8 @@ public struct UsageModel
         public int NumberOfPRDetailsNavigateToEditor { get; set; }
         public int NumberOfPRReviewDiffViewInlineCommentOpen { get; set; }
         public int NumberOfPRReviewDiffViewInlineCommentPost { get; set; }
+        public int NumberOfPRReviewDiffViewInlineCommentStartReview { get; set; }
+        public int NumberOfPRReviewPosts { get; set; }
         public int NumberOfShowCurrentPullRequest { get; set; }
 
         public UsageModel Clone(bool includeWeekly, bool includeMonthly)
diff --git a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs b/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
index b8349994e6..64b914f1d7 100644
--- a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
+++ b/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
@@ -344,7 +344,9 @@ public async Task<IPullRequestReviewModel> CreatePendingReview(
                     User = user,
                 });
 
-            return await graphql.Run(addReview);
+            var result = await graphql.Run(addReview);
+            await usageTracker.IncrementCounter(x => x.NumberOfPRReviewDiffViewInlineCommentStartReview);
+            return result;
         }
 
         /// <inheritdoc/>
@@ -368,6 +370,8 @@ public async Task<IPullRequestReviewModel> PostReview(
                 body,
                 e);
 
+            await usageTracker.IncrementCounter(x => x.NumberOfPRReviewPosts);
+
             return new PullRequestReviewModel
             {
                 Id = result.Id,
@@ -407,7 +411,9 @@ public async Task<IPullRequestReviewModel> SubmitPendingReview(
                     User = user,
                 });
 
-            return await graphql.Run(mutation);
+            var result = await graphql.Run(mutation);
+            await usageTracker.IncrementCounter(x => x.NumberOfPRReviewPosts);
+            return result;
         }
 
         /// <inheritdoc/>
@@ -451,7 +457,9 @@ public async Task<IPullRequestReviewCommentModel> PostPendingReviewComment(
                     IsPending = true,
                 });
 
-            return await graphql.Run(addComment);
+            var result = await graphql.Run(addComment);
+            await usageTracker.IncrementCounter(x => x.NumberOfPRReviewDiffViewInlineCommentPost);
+            return result;
         }
 
         /// <inheritdoc/>
@@ -491,7 +499,9 @@ public async Task<IPullRequestReviewCommentModel> PostPendingReviewCommentReply(
                     IsPending = true,
                 });
 
-            return await graphql.Run(addComment);
+            var result = await graphql.Run(addComment);
+            await usageTracker.IncrementCounter(x => x.NumberOfPRReviewDiffViewInlineCommentPost);
+            return result;
         }
 
         /// <inheritdoc/>