-
Notifications
You must be signed in to change notification settings - Fork 417
Python: Handle new default for standard library extraction #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
probably still need to route some values around
fcaf886 to
ce5f900
Compare
tausbn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
(However, I'm not familiar with most aspects of how codeql-action works, so we should probably get someone from the core team to give the go-ahead before merging.)
henrymercer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, both on the thinking and the code :)
When you review this, could you also confirm my thinking on the following?
feature-flags.ts:Feature.CodeqlActionPythonDefaultIsToNotExtractStdlibwill be(come) true iff(((the feature flag is on AND NOT the disabling feature flag is on) OR the environment variable is set to true) AND NOT the environment variable is set to false) AND
ToolsFeature.PythonDefaultIsToNotExtractStdlibis true.x_disabled), and the environment variable. And the tools feature takes precedence, then the environment variable, then the disabling feature flag, then the feature flag."CODEQL_ACTION_DISABLE_PYTHON_STANDARD_LIBRARY_EXTRACTION"is now available to the action.src/tools-features.ts:ToolsFeature.PythonDefaultIsToNotExtractStdlibis now received from the CLI as long as the entry in there is calledpythonDefaultIsToNotExtractStdlibToolsFeature.PythonDefaultIsToNotExtractStdlibwill simply be off.Merge / deployment checklist