Skip to content

Commit 0de878d

Browse files
authored
Merge pull request #24999 from github/repo-sync
repo sync
2 parents a5bf466 + 78861a7 commit 0de878d

File tree

40 files changed

+5164
-5229
lines changed

40 files changed

+5164
-5229
lines changed
17.2 KB
Loading
112 KB
Loading

content/code-security/secret-scanning/about-secret-scanning.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,17 @@ If your project communicates with an external service, you might use a token or
2828

2929
{% data variables.product.prodname_secret_scanning_caps %} will scan your entire Git history on all branches present in your {% data variables.product.prodname_dotcom %} repository for secrets{% ifversion ghec or ghes > 3.4 or ghae > 3.4 %}, even if the repository is archived{% endif %}. {% ifversion secret-scanning-issue-body-comments %}{% data reusables.secret-scanning.scan-issue-description-and-comments %}{% endif %}
3030

31+
{% ifversion secret-scanning-backfills-historical-issues %}
32+
{% data variables.product.prodname_secret_scanning_caps %} also scans the titles, descriptions, and comments, in open and closed historical issues, and reports leaked secrets as alerts on {% data variables.product.prodname_dotcom %}{% ifversion ghec %}. A notification is sent to the relevant partner when a historical partner pattern is detected{% endif %}.
33+
34+
{% note %}
35+
36+
**Note:** {% data variables.product.prodname_secret_scanning_caps %} for historical secret leaks is currently in public beta and subject to change.
37+
38+
{% endnote %}
39+
40+
{% endif %}
41+
3142
{% ifversion fpt or ghec %}
3243
{% data variables.product.prodname_secret_scanning_caps %} is available on {% data variables.product.prodname_dotcom_the_website %} in two forms:
3344

content/migrations/using-ghe-migrator/about-ghe-migrator.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ The items in the table below can be migrated with a repository. Any items not sh
5151
| Issue comments | Cross-references to comments are rewritten for the target instance.
5252
| Pull requests | Cross-references to pull requests are rewritten to match the target. Timestamps are preserved.
5353
| Pull request reviews | Pull request reviews and associated data are migrated.
54-
| Pull request review comments | Cross-references to comments are rewritten for the target instance. Timestamps are preserved.
54+
| Pull request review comments | Cross-references to comments are rewritten for the target instance. Timestamps are preserved. File-level comments are not migrated.
5555
| Commit comments | Cross-references to comments are rewritten for the target instance. Timestamps are preserved.
5656
| Releases | All releases data is migrated.
5757
| Actions taken on pull requests or issues | All modifications to pull requests or issues, such as assigning users, renaming titles, and modifying labels are preserved, along with timestamps for each action.

content/webhooks-and-events/webhooks/receiving-webhooks-with-the-github-cli.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ redirect_from:
1313

1414
When you make changes to your integration code, running the code in a local environment lets you test and iterate quickly without deploying the code. You can use {% data variables.product.prodname_cli %} to forward webhooks to your local environment.
1515

16-
{% note %}
16+
Webhook forwarding in the {% data variables.product.prodname_cli %} only works with repository and organization webhooks. If you want to test sponsorship, GitHub App, enterprise, or Marketplace webhooks locally, you'll need to do this manually. For more information, see "[AUTOTITLE](/webhooks-and-events/webhooks/creating-webhooks).
1717

18-
**Note:** Webhook forwarding in the {% data variables.product.prodname_cli %} only works with repository and organization webhooks. If you want to test sponsorship, GitHub App, enterprise, or Marketplace webhooks locally, you'll need to do this manually. For more information, see "[AUTOTITLE](/webhooks-and-events/webhooks/creating-webhooks)."
18+
{% warning %}
1919

20-
{% endnote %}
20+
**Warning**: Webhook forwarding is only designed for use during testing and development. It is not supported for use in production environments for handling live webhooks.
21+
22+
{% endwarning %}
2123

2224
## Receiving webhooks with {% data variables.product.prodname_cli %}
2325

@@ -45,3 +47,9 @@ When you make changes to your integration code, running the code in a local envi
4547
```
4648

4749
Leave the command running in the background. It will receive all of the specified events for the specified repository and forward them to your webhook handler running at the specified URL.
50+
51+
{% note %}
52+
53+
**Note**: Only one person can use webhook forwarding at a time for each repository and organization. If you try to set up webhook forwarding and someone else is already working with that organization or repository, you'll receive a `Hook already exists` error.
54+
55+
{% endnote %}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Reference: #9139.
2+
# Documentation for secret scanning detects secrets in historical issues content.
3+
versions:
4+
ghec: '*'
5+
ghes: '>=3.9'

data/reusables/repositories/request-changes-tips.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{% tip %}
22

33
**Tips**:
4-
- If required reviews are enabled and a collaborator with _write_, _admin_, or _owner_ access to the repository submits a review requesting changes, the pull request cannot be merged until the same collaborator submits another review approving the changes in the pull request.
4+
- If a collaborator with `admin`, `owner`, or `write` access to the repository submits a review requesting changes, the pull request cannot be merged until the same collaborator submits another review approving the changes in the pull request.
55
- Repository owners and administrators can merge a pull request even if it hasn't received an approving review, or if a reviewer who requested changes has left the organization or is unavailable.
66
- If both required reviews and stale review dismissal are enabled and a code-modifying commit is pushed to the branch of an approved pull request, the approval is dismissed. The pull request must be reviewed and approved again before it can be merged.
77
- When several open pull requests each have a head branch pointing to the same commit, you won’t be able to merge them if one or both have a pending or rejected review.

data/secret-scanning.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@
374374
ghec: '*'
375375
ghes: '>=3.9'
376376
ghae: '>=3.9'
377-
isPublic: false
377+
isPublic: true
378378
isPrivateWithGhas: true
379379
hasPushProtection: true
380380
hasValidityCheck: false

lib/render-content/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ You can add a header to code blocks by adding the `{:copy}` annotation after the
4747

4848
This renders:
4949

50-
![image](https://user-images.githubusercontent.com/10660468/95881747-e96c6900-0d46-11eb-9abf-1e8ad16c7646.png)
50+
![Screenshot of a code block showing the clipboard icon that is displayed when you use `{:copy}` annotation.](/assets/images/internal-docs/copy-block-header.png)
5151

5252
The un-highlighted text is available as `button.js-btn-copy`'s `data-clipboard-text` attribute.

0 commit comments

Comments
 (0)