fix github/no-then violations

Author: koddsson

bin/eslint-github-init.js

@@ -47,7 +47,7 @@ const questions = [
   }
 ]
 
-inquirer.prompt(questions).then(answers => {
+for (const answers of inquirer.prompt(questions)) {
   const eslintrc = {extends: ['plugin:github/es6']}
 
   if (answers.project === 'app') {
@@ -83,4 +83,4 @@ inquirer.prompt(questions).then(answers => {
   prettierConfig.push('')
 
   fs.writeFileSync(path.resolve(process.cwd(), 'prettier.config.js'), prettierConfig.join('\n'), 'utf8')
-})
+}

bin/github-lint.js

@@ -17,48 +17,50 @@ function execFile(command, args) {
   })
 }
 
-;(async function() {
-  let runs = 0
-  const codes = []
-  const commands = []
+try {
+  ;(async function() {
+    let runs = 0
+    const codes = []
+    const commands = []
 
-  let eslintOptions = ['--report-unused-disable-directives', '.']
+    let eslintOptions = ['--report-unused-disable-directives', '.']
 
-  if (hasBasicColorSupport) {
-    eslintOptions = eslintOptions.concat(['--color'])
-  }
+    if (hasBasicColorSupport) {
+      eslintOptions = eslintOptions.concat(['--color'])
+    }
 
-  const isTypeScriptProject = fs.existsSync('tsconfig.json')
+    const isTypeScriptProject = fs.existsSync('tsconfig.json')
 
-  if (isTypeScriptProject) {
-    eslintOptions = eslintOptions.concat(['--ext', '.js,.ts,.tsx'])
-  }
+    if (isTypeScriptProject) {
+      eslintOptions = eslintOptions.concat(['--ext', '.js,.ts,.tsx'])
+    }
 
-  commands.push(['eslint', eslintOptions])
+    commands.push(['eslint', eslintOptions])
 
-  if (isTypeScriptProject) {
-    commands.push(['tsc', ['--noEmit']])
-  }
+    if (isTypeScriptProject) {
+      commands.push(['tsc', ['--noEmit']])
+    }
 
-  for (const [command, args] of commands) {
-    if (runs > 0) process.stderr.write('\n')
-    process.stderr.write(`> ${command} ${args.join(' ')}\n`)
+    for (const [command, args] of commands) {
+      if (runs > 0) process.stderr.write('\n')
+      process.stderr.write(`> ${command} ${args.join(' ')}\n`)
 
-    const {code, stdout, stderr} = await execFile(command, args)
-    codes.push(code)
-    if (stderr) process.stderr.write(stderr)
-    if (stdout) process.stdout.write(stdout)
+      const {code, stdout, stderr} = await execFile(command, args)
+      codes.push(code)
+      if (stderr) process.stderr.write(stderr)
+      if (stdout) process.stdout.write(stdout)
 
-    runs++
-  }
+      runs++
+    }
 
-  const nonzero = codes.find(code => code !== 0)
-  if (nonzero) {
-    process.stderr.write(`\nCommand failed: ${nonzero}\n`)
-    process.exit(nonzero)
-  }
-})().catch(error => {
+    const nonzero = codes.find(code => code !== 0)
+    if (nonzero) {
+      process.stderr.write(`\nCommand failed: ${nonzero}\n`)
+      process.exit(nonzero)
+    }
+  })
+} catch (error) {
   setTimeout(() => {
     throw error
   })
-})
+}

bin/npm-check-github-package-requirements.js

@@ -12,10 +12,13 @@ function run() {
   process.stdout.write(`1..${checks.length}\n`)
   for (const [count, name, callback] of checks) {
     Promise.resolve()
+      // eslint-disable-next-line github/no-then
       .then(callback)
+      // eslint-disable-next-line github/no-then
       .then(() => {
         process.stdout.write(`ok ${count} - ${name}\n`)
       })
+      // eslint-disable-next-line github/no-then
       .catch(error => {
         process.stdout.write(`not ok ${count} - ${name}\n  ${error}\n`)
       })