Handle multiple srcsets when first is remote

Author: paulroub

lib/html_proofer/check/images.rb

@@ -20,18 +20,6 @@ def run
           # does the image exist?
           if missing_src?
             add_failure("image has no src or srcset attribute", element: @img)
-          elsif @img.url.protocol_relative?
-            add_failure(
-              "image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
-              element: @img,
-            )
-          elsif @img.url.remote?
-            add_to_external_urls(@img.url, @img.line)
-          elsif !@img.url.exists? && !@img.multiple_srcsets? && !@img.multiple_sizes?
-            add_failure(
-              "internal image #{@img.url.raw_attribute} does not exist",
-              element: @img,
-            )
           elsif @img.multiple_srcsets? || @img.multiple_sizes?
             @img.srcsets_wo_sizes.each do |srcset|
               srcset_url = HTMLProofer::Attribute::Url.new(@runner, srcset, base_url: @img.base_url, source: @img.url.source, filename: @img.url.filename, extract_size: true)
@@ -47,6 +35,18 @@ def run
                 add_failure("internal image #{srcset} does not exist", element: @img)
               end
             end
+          elsif @img.url.protocol_relative?
+            add_failure(
+              "image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
+              element: @img,
+            )
+          elsif @img.url.remote?
+            add_to_external_urls(@img.url, @img.line)
+          elsif !@img.url.exists? && !@img.multiple_srcsets? && !@img.multiple_sizes?
+            add_failure(
+              "internal image #{@img.url.raw_attribute} does not exist",
+              element: @img,
+            )
           end
 
           # if this is an img element, check that the alt attribute is present

spec/html-proofer/check/images_spec.rb

@@ -278,6 +278,12 @@
     expect(proofer.failed_checks).to(eq([]))
   end
 
+  it "works for picture elements with multiple remote sizes" do
+    custom_data_src_check = "#{FIXTURES_DIR}/images/srcset_picture_remote_sizes.html"
+    proofer = run_proofer(custom_data_src_check, :file)
+    expect(proofer.failed_checks).to(eq([]))
+  end
+
   it "breaks for picture elements with multiple srcsets and pixel densities" do
     custom_data_src_check = "#{FIXTURES_DIR}/images/srcset_picture_pixel-density_broken.html"
     proofer = run_proofer(custom_data_src_check, :file)

spec/html-proofer/fixtures/images/srcset_picture_remote_sizes.html

@@ -0,0 +1,12 @@
+<picture>
+    <!--[if IE 9]><video style="display: none;"><![endif]-->
+    <source
+        srcset="
+            https://upload.wikimedia.org/wikipedia/en/thumb/2/22/Heckert_GNU_white.svg/256px-Heckert_GNU_white.svg.png 2x,
+            https://upload.wikimedia.org/wikipedia/en/2/22/Heckert_GNU_white.svg                                       1x
+        "
+        type="image/webp"
+    />
+    <!--[if IE 9]></video><![endif]-->
+    <img srcset="gpl.png" alt="test" />
+</picture>