Skip to content

Conversation

@Calinou
Copy link
Member

@Calinou Calinou commented Feb 24, 2025

This now contains a screenshot that shows how to set the anchor preset.

This also renames the half variable in the example shader to avoid highlighting half as a GLSL language keyword:

image

…sing

This now contains a screenshot that shows how to set the anchor preset.

This also renames the `half` variable in the example shader to avoid
highlighting `half` as a GLSL language keyword.
@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 labels Feb 24, 2025
@Calinou Calinou added this to the 4.4 milestone Feb 24, 2025
@tetrapod00
Copy link
Contributor

tetrapod00 commented Feb 24, 2025

Would supersede #10712 if merged

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine and so does #10712. I slightly prefer the other one since the image isn't strictly required. If we choose the other one, the less_than_half change is still good anyway

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed "anchors preset" to "anchor preset" since that's what it's called in the toolbar dropdown. I'm now seeing that it's called "anchors preset" in the Inspector and we really need to get that fixed in engine.

That aside I'd prefer this one specifically because of the image. I don't think #10712 gives enough info on where the setting is on its own.

@skyace65
Copy link
Contributor

Given the 3 approvals compared to the one approval on the other PR I'll take this as the preferred one

@skyace65 skyace65 merged commit 721603d into godotengine:master Feb 27, 2025
2 checks passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 enhancement topic:shaders

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants