-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update instructions on setting Full Rect anchor in Custom post-processing #10714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions on setting Full Rect anchor in Custom post-processing #10714
Conversation
…sing This now contains a screenshot that shows how to set the anchor preset. This also renames the `half` variable in the example shader to avoid highlighting `half` as a GLSL language keyword.
|
Would supersede #10712 if merged |
tetrapod00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine and so does #10712. I slightly prefer the other one since the image isn't strictly required. If we choose the other one, the less_than_half change is still good anyway
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed "anchors preset" to "anchor preset" since that's what it's called in the toolbar dropdown. I'm now seeing that it's called "anchors preset" in the Inspector and we really need to get that fixed in engine.
That aside I'd prefer this one specifically because of the image. I don't think #10712 gives enough info on where the setting is on its own.
Co-authored-by: A Thousand Ships <[email protected]>
|
Given the 3 approvals compared to the one approval on the other PR I'll take this as the preferred one |
|
Thanks! |
This now contains a screenshot that shows how to set the anchor preset.
This also renames the
halfvariable in the example shader to avoid highlightinghalfas a GLSL language keyword: