Skip to content

Commit 28cdff9

Browse files
committed
test: Rename testInfos to testEntries
Because os.ReadDir returns []DirEntry.
1 parent 7a98035 commit 28cdff9

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

zip/zip_test.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -398,21 +398,21 @@ func TestCheckZip(t *testing.T) {
398398

399399
func TestCreate(t *testing.T) {
400400
testDir := filepath.FromSlash("testdata/create")
401-
testInfos, err := os.ReadDir(testDir)
401+
testEntries, err := os.ReadDir(testDir)
402402
if err != nil {
403403
t.Fatal(err)
404404
}
405-
for _, testInfo := range testInfos {
406-
testInfo := testInfo
407-
base := filepath.Base(testInfo.Name())
405+
for _, testEntry := range testEntries {
406+
testEntry := testEntry
407+
base := filepath.Base(testEntry.Name())
408408
if filepath.Ext(base) != ".txt" {
409409
continue
410410
}
411411
t.Run(base[:len(base)-len(".txt")], func(t *testing.T) {
412412
t.Parallel()
413413

414414
// Load the test.
415-
testPath := filepath.Join(testDir, testInfo.Name())
415+
testPath := filepath.Join(testDir, testEntry.Name())
416416
test, err := readTest(testPath)
417417
if err != nil {
418418
t.Fatal(err)
@@ -461,21 +461,21 @@ func TestCreate(t *testing.T) {
461461

462462
func TestCreateFromDir(t *testing.T) {
463463
testDir := filepath.FromSlash("testdata/create_from_dir")
464-
testInfos, err := os.ReadDir(testDir)
464+
testEntries, err := os.ReadDir(testDir)
465465
if err != nil {
466466
t.Fatal(err)
467467
}
468-
for _, testInfo := range testInfos {
469-
testInfo := testInfo
470-
base := filepath.Base(testInfo.Name())
468+
for _, testEntry := range testEntries {
469+
testEntry := testEntry
470+
base := filepath.Base(testEntry.Name())
471471
if filepath.Ext(base) != ".txt" {
472472
continue
473473
}
474474
t.Run(base[:len(base)-len(".txt")], func(t *testing.T) {
475475
t.Parallel()
476476

477477
// Load the test.
478-
testPath := filepath.Join(testDir, testInfo.Name())
478+
testPath := filepath.Join(testDir, testEntry.Name())
479479
test, err := readTest(testPath)
480480
if err != nil {
481481
t.Fatal(err)
@@ -591,18 +591,18 @@ func TestCreateFromDirSpecial(t *testing.T) {
591591

592592
func TestUnzip(t *testing.T) {
593593
testDir := filepath.FromSlash("testdata/unzip")
594-
testInfos, err := os.ReadDir(testDir)
594+
testEntries, err := os.ReadDir(testDir)
595595
if err != nil {
596596
t.Fatal(err)
597597
}
598-
for _, testInfo := range testInfos {
599-
base := filepath.Base(testInfo.Name())
598+
for _, testEntry := range testEntries {
599+
base := filepath.Base(testEntry.Name())
600600
if filepath.Ext(base) != ".txt" {
601601
continue
602602
}
603603
t.Run(base[:len(base)-len(".txt")], func(t *testing.T) {
604604
// Load the test.
605-
testPath := filepath.Join(testDir, testInfo.Name())
605+
testPath := filepath.Join(testDir, testEntry.Name())
606606
test, err := readTest(testPath)
607607
if err != nil {
608608
t.Fatal(err)

0 commit comments

Comments
 (0)