fix: Fix timeout default values #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix LRO for REST transport. This PR makes generated gapics appeciate timeout values from grpc_service_config.json instead of overriding them with None (which means no timeout) It is basically a direct fix for googleapis#1477. This PR depends on googleapis/python-api-core#462, and expects `setup.py.j2` templates to be updated after googleapis/python-api-core#462 gets pushed and released with new version.
Contributor
Author
|
@igorbernstein2 PTAL |
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
the default looks correct, but maybe you want to use type-extensions to narrow the type annotation to a Literal instead of object?
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix LRO for REST transport. This PR makes generated gapics appreciate timeout values from grpc_service_config.json instead of overriding them with None (which means no timeout)
It is basically a direct fix for #1477.
This PR depends on googleapis/python-api-core#462, and expects
setup.py.j2templates to be updated after googleapis/python-api-core#462 gets pushed and released with new version.BEGIN_COMMIT_OVERRIDE
fix: Fix timeout default values
fix(deps): require google-api-core >=1.34.0, >=2.11.0
END_COMMIT_OVERRIDE
Fixes #1477.