feat: Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radhika Agrawal <[email protected]>
Signed-off-by: Radhika Agrawal <[email protected]>
agrawalradhika-cell
changed the title
yoshi-kokoro
removed
the
kokoro:run
Signed-off-by: Radhika Agrawal <[email protected]>
Signed-off-by: Radhika Agrawal <[email protected]>
nbayati
reviewed
Nov 5, 2025
Contributor
nbayati
left a comment
nbayati
left a comment
There was a problem hiding this comment.
Overall LGTM, I just have a minor suggestion: Add a test case to verify the behavior when GOOGLE_API_USE_CLIENT_CERTIFICATE is set to a string other than "true" or "false". The current implementation correctly evaluates such cases to False, and adding an explicit test for this would make the test suite more comprehensive.
daniel-sanche
previously approved these changes
Nov 5, 2025
Contributor
daniel-sanche
left a comment
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, but one more small comment
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Signed-off-by: Radhika Agrawal <[email protected]>
nbayati
approved these changes
Nov 5, 2025
yaoliugg
approved these changes
Nov 5, 2025
nbayati
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
andyrzhao
added
the
kokoro:run
andyrzhao
approved these changes
Nov 5, 2025
Contributor
andyrzhao
left a comment
andyrzhao
left a comment
There was a problem hiding this comment.
lgtm, thanks for working on this!
daniel-sanche
approved these changes
Nov 5, 2025
yoshi-kokoro
removed
the
kokoro:run
This was referenced Nov 5, 2025
Linchin
added a commit
that referenced
this pull request
Nov 5, 2025
Librarian Version: v0.5.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest <details><summary>google-auth: 2.43.0</summary> ## [2.43.0](v2.42.1...v2.43.0) (2025-11-05) ### Features * Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected (#1859) ([1535ecc](1535eccb)) * Enable mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, if the MWID/X.509 cert sources detected (#1848) ([395e405](395e405b)) * onboard `google-auth` to librarian (#1838) ([c503eaa](c503eaa5)) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add public wrapper for check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected. Also, fix check_use_client_cert to return boolean value.
Change #1848 added the check_use_client_cert method that helps know if client cert should be used for mTLS connection. However, that was in a private class, thus, created a public wrapper of the same function so that it can be used by python Client Libraries. Also, updated check_use_client_cert to return a boolean value instead of existing string value for better readability and future scope.