Skip to content

Commit 193da93

Browse files
authored
chore: migrate to owl bot (#48)
This PR migrates from autosynth to [owl bot](https://github.com/googleapis/repo-automation-bots/tree/master/packages/owl-bot). owl bot will save time for maintainers as it will automatically open PRs when there are updates in [googleapis-gen](https://github.com/googleapis/googleapis-gen/tree/master/google) without requiring maintainers to run `synthtool` to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates.
1 parent c33b385 commit 193da93

File tree

7 files changed

+39
-179
lines changed

7 files changed

+39
-179
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
docker:
2+
digest: sha256:457583330eec64daa02aeb7a72a04d33e7be2428f646671ce4045dcbc0191b1e
3+
image: gcr.io/repo-automation-bots/owlbot-python:latest
4+
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Copyright 2021 Google LLC
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
docker:
16+
image: gcr.io/repo-automation-bots/owlbot-python:latest
17+
18+
deep-remove-regex:
19+
- /owl-bot-staging
20+
21+
deep-copy-regex:
22+
- source: /google/cloud/video/transcoder/(v.*)/.*-py/(.*)
23+
dest: /owl-bot-staging/$1/$2
24+
25+
begin-after-commit-hash: 19c469f0eefe7735eb3d6438773f12dd88060da1
26+

packages/google-cloud-video-transcoder/.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ repos:
2626
hooks:
2727
- id: black
2828
- repo: https://gitlab.com/pycqa/flake8
29-
rev: 3.9.0
29+
rev: 3.9.1
3030
hooks:
3131
- id: flake8

packages/google-cloud-video-transcoder/CONTRIBUTING.rst

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -160,21 +160,7 @@ Running System Tests
160160
auth settings and change some configuration in your project to
161161
run all the tests.
162162

163-
- System tests will be run against an actual project and
164-
so you'll need to provide some environment variables to facilitate
165-
authentication to your project:
166-
167-
- ``GOOGLE_APPLICATION_CREDENTIALS``: The path to a JSON key file;
168-
Such a file can be downloaded directly from the developer's console by clicking
169-
"Generate new JSON key". See private key
170-
`docs <https://cloud.google.com/storage/docs/authentication#generating-a-private-key>`__
171-
for more details.
172-
173-
- Once you have downloaded your json keys, set the environment variable
174-
``GOOGLE_APPLICATION_CREDENTIALS`` to the absolute path of the json file::
175-
176-
$ export GOOGLE_APPLICATION_CREDENTIALS="/Users/<your_username>/path/to/app_credentials.json"
177-
163+
- System tests will be run against an actual project. You should use local credentials from gcloud when possible. See `Best practices for application authentication <https://cloud.google.com/docs/authentication/best-practices-applications#local_development_and_testing_with_the>`__. Some tests require a service account. For those tests see `Authenticating as a service account <https://cloud.google.com/docs/authentication/production>`__.
178164

179165
*************
180166
Test Coverage

packages/google-cloud-video-transcoder/noxfile.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,9 @@ def lint(session):
6262
session.run("flake8", "google", "tests")
6363

6464

65-
@nox.session(python="3.6")
65+
@nox.session(python=DEFAULT_PYTHON_VERSION)
6666
def blacken(session):
67-
"""Run black.
68-
69-
Format code to uniform standard.
70-
71-
This currently uses Python 3.6 due to the automated Kokoro run of synthtool.
72-
That run uses an image that doesn't have 3.6 installed. Before updating this
73-
check the state of the `gcp_ubuntu_config` we use for that Kokoro run.
74-
"""
67+
"""Run black. Format code to uniform standard."""
7568
session.install(BLACK_VERSION)
7669
session.run(
7770
"black", *BLACK_PATHS,
@@ -131,9 +124,6 @@ def system(session):
131124
# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
132125
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
133126
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
134-
# Sanity check: Only run tests if the environment variable is set.
135-
if not os.environ.get("GOOGLE_APPLICATION_CREDENTIALS", ""):
136-
session.skip("Credentials must be set via environment variable")
137127
# Install pyopenssl for mTLS testing.
138128
if os.environ.get("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false") == "true":
139129
session.install("pyopenssl")

packages/google-cloud-video-transcoder/synth.py renamed to packages/google-cloud-video-transcoder/owlbot.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,24 @@
1919
import synthtool.gcp as gcp
2020
from synthtool.languages import python
2121

22-
gapic = gcp.GAPICBazel()
2322
common = gcp.CommonTemplates()
2423

25-
# ----------------------------------------------------------------------------
26-
# Generate transcoder GAPIC layer
27-
# ----------------------------------------------------------------------------
28-
versions = ["v1beta1"]
29-
for version in versions:
30-
library = gapic.py_library(
31-
service="transcoder",
32-
version=version,
33-
bazel_target=f"//google/cloud/video/transcoder/{version}:video-transcoder-{version}-py",
34-
)
24+
default_version = "v1beta1"
3525

26+
for library in s.get_staging_dirs(default_version):
3627
s.move(
3728
library,
3829
excludes=[
3930
"setup.py",
4031
"README.rst",
4132
"docs/index.rst",
4233
"noxfile.py",
43-
f"scripts/fixup_transcoder_{version}_keywords.py",
34+
f"scripts/fixup_transcoder_{library.name}_keywords.py",
4435
],
4536
)
4637

38+
s.remove_staging_dirs()
39+
4740
# ----------------------------------------------------------------------------
4841
# Add templated files
4942
# ----------------------------------------------------------------------------

packages/google-cloud-video-transcoder/synth.metadata

Lines changed: 0 additions & 139 deletions
This file was deleted.

0 commit comments

Comments
 (0)