Skip to content

Fix test assertion in test_wrap_method_with_overriding_retry_deadline #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2017
Merged

Fix test assertion in test_wrap_method_with_overriding_retry_deadline #4131

merged 2 commits into from
Oct 6, 2017

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Oct 6, 2017

Fixes #4128

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2017
dhermes
dhermes reviewed Oct 6, 2017
View reviewed changes
core/tests/unit/api_core/gapic/test_method.py Outdated
timeout_args = [call[1]['timeout'] for call in method.call_args_list]
assert timeout_args == [5, 10, 20, 29]
# Timeout should never exceed 30s.
assert max(timeout_args) <= 30

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

googlebot commented Oct 6, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 6, 2017
dhermes
dhermes reviewed Oct 6, 2017
View reviewed changes
core/tests/unit/api_core/gapic/test_method.py
assert utcnow.call_count == (
1 + # First to set the deadline.
5 + # One for each min(timeout, maximum, (DEADLINE - NOW).seconds)
5

This comment was marked as spam.

Sign in to view

@dhermes dhermes merged commit 3123de6 into googleapis:master Oct 6, 2017
@theacodes theacodes mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes @googlebot @dhermes