Add google.api_core.gapic_v2.client_info #4225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
@lukesneeringer @dhermes this is my attempt to fix #4068 without making myself angry. I'm open to feedback and suggestions at alternatives. |
| Args: | ||
| python_version (str): The Python interpreter version, for example, | ||
| ``'2.7.13'``. | ||
| grpc_version (st): The gRPC library version. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| ``'2.7.13'``. | ||
| grpc_version (st): The gRPC library version. | ||
| api_core_version (str): The google-api-core library version. | ||
| gapic_version (Optional[str]): The version of gapic used to generate |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Oct 19, 2017
Contributor
lukesneeringer
left a comment
lukesneeringer
left a comment
There was a problem hiding this comment.
LGTM other than the two nits. I can fix the nits if you like (I will in a few minutes if you do not get to it first.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4068