Skip to content

Port gax helper methods #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2017
Merged

Port gax helper methods #4249

merged 4 commits into from
Oct 25, 2017

Conversation

@landrito
Copy link
Contributor

@landrito landrito commented Oct 24, 2017

No description provided.

@landrito landrito requested a review from theacodes October 24, 2017 22:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
theacodes
theacodes reviewed Oct 24, 2017
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, a few tiny nits. Thank you for doing this.

api_core/google/api_core/protobuf_helpers.py Outdated
"""Raise ValueError if more than one keyword argument is not none.
Args:
kwargs (dict): The keyword arguments sent to the function.
Returns: None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

api_core/google/api_core/protobuf_helpers.py Outdated
"""
# Sanity check: If no keyword arguments were sent, this is fine.
if not kwargs:
return None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

theacodes
theacodes reviewed Oct 24, 2017
View reviewed changes
api_core/tests/unit/test_protobuf_helpers.py Outdated
assert protobuf_helpers.check_oneof(foo='bar') is None
assert protobuf_helpers.check_oneof(foo='bar', baz=None) is None
assert protobuf_helpers.check_oneof(foo=None, baz='bacon') is None
assert (protobuf_helpers.check_oneof(foo='bar', spam=None, eggs=None)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@landrito landrito mentioned this pull request Oct 24, 2017
Merged
5 tasks
@theacodes
Copy link
Contributor

theacodes commented Oct 24, 2017

There's an unrelated lint error blocking this, I sent #4250 to fix. Can you verify that nox -s "unit_tests(python_version='3.6')" works locally? if so, I'm happy to merge this as-is without waiting to rebase.

@landrito
Copy link
Contributor Author

landrito commented Oct 24, 2017

That command ran successfully.

@theacodes theacodes merged commit 877ef4e into googleapis:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@theacodes theacodes theacodes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@landrito @theacodes @googlebot