feat: support with_call for wrapped rpcs #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
approved these changes
Nov 9, 2023
Contributor
|
@daniel-sanche Could you fix the lint error? |
Contributor
Author
fixed, thanks |
This was referenced May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most grpc calls return a
grpc.Callobject, that contains trailing metadata and other useful information. You can thenawait(for async unary rpcs) or iterate over (for streaming rpcs) the Call object to get the proto results of the rpc.This is not the case for unary synchronous calls, because there is no intermediate object. Calling the rpc results in the value directly. The grpc library provides
with_callmethods for this reason, which return a tuple of the rpc result and the Call object.Currently, the gapic wrapper does not provide a way to access this data
This PR solves the issue by adding
with_callto thewrap_methodfunction, which will is passed down to the grpc callable