Skip to content

Conversation

@vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Sep 4, 2025

Some test methods to test async functionality had @pytest.mark.asyncio but were not themselves designated as async methods. This led to warnings.

Some of the tests also started failing under Python 3.14 because the numeric comparisons were not exact. These changes makes those expectations be somewhat approximate.

@vchudnov-g vchudnov-g requested review from a team as code owners September 4, 2025 19:50
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 4, 2025
@vchudnov-g vchudnov-g marked this pull request as draft September 4, 2025 19:50
@vchudnov-g vchudnov-g force-pushed the version-support--check-main branch from fbbbab4 to 83c1491 Compare September 4, 2025 19:51
@vchudnov-g vchudnov-g force-pushed the version-support--check-main branch from 83c1491 to 6966a1a Compare September 4, 2025 19:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 4, 2025
@vchudnov-g vchudnov-g changed the title fix: properly designate async test methods fix: fix async tests Sep 4, 2025
@vchudnov-g vchudnov-g changed the title fix: fix async tests fix: fix async tests and round-off error in test expectations Sep 4, 2025
@vchudnov-g vchudnov-g requested review from ohmayr and parthea September 4, 2025 22:24
@vchudnov-g vchudnov-g marked this pull request as ready for review September 4, 2025 22:25
@vchudnov-g vchudnov-g merged commit 14a5978 into main Sep 4, 2025
48 checks passed
@vchudnov-g vchudnov-g deleted the version-support--check-main branch September 4, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants