Skip to content

Conversation

@busunkim96
Copy link
Contributor

https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0 dropped Python 2 support. Python 3 users can continue to use the latest version of protobuf with google-api-core 1.x releases.

This PR is being made to the v1 branch. Changes will be released manually as the next 1.x release, 1.31.4.

Fixes googleapis/python-aiplatform#830.

https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0 dropped Python 2 support. Python 3 users can continue to use the latest version of protobuf.
@busunkim96 busunkim96 requested a review from a team as a code owner November 8, 2021 19:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
"googleapis-common-protos >= 1.6.0, < 2.0dev",
"protobuf >= 3.12.0, < 3.18.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally added as python 2 users were getting unintended protobuf upgrades - see #276 and #277

@busunkim96
Copy link
Contributor Author

Everything except for docfx passed, merging:

html -d docs/_build/doctrees/ docs/ docs/_build/html/ failed with exit code 2
nox > Session docfx failed.
nox > Ran multiple sessions:
nox > * lint: success
nox > * blacken: success
nox > * unit-2.7: success
nox > * unit-3.6: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * unit_grpc_gcp-2.7: success
nox > * unit_grpc_gcp-3.6: success
nox > * unit_grpc_gcp-3.7: success
nox > * unit_grpc_gcp-3.8: success
nox > * unit_grpc_gcp-3.9: success
nox > * lint_setup_py: success
nox > * pytype: success
nox > * cover: success
nox > * docs: success
nox > * docfx: failed
cleanup

@busunkim96 busunkim96 merged commit 286347e into v1 Nov 8, 2021
@busunkim96 busunkim96 deleted the busunkim96-patch-1 branch November 8, 2021 20:52
@busunkim96 busunkim96 mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants