Skip to content

Conversation

@chelsea-lin
Copy link
Contributor

This change is re-enabling the unittest workflow in Owlbot configuration. This workflow was previously disabled in #948 but is now reintroduced due to a fix in Synthtool.

@chelsea-lin chelsea-lin requested a review from shobsi September 16, 2024 19:19
@chelsea-lin chelsea-lin requested review from a team as code owners September 16, 2024 19:19
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 16, 2024
@chelsea-lin chelsea-lin marked this pull request as draft September 16, 2024 20:39
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review September 17, 2024 18:27
Copy link
Contributor

@shobsi shobsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make something pass that is failing right now? Or it is redundant (we don't need anymore) because the hidden directories are honored by default now?

@chelsea-lin
Copy link
Contributor Author

@shobsi It is not fixing anything but it's nice to bring the exclude file back to sync up with the upstream template. The file was excluded because of the hidden directories bug was not fixed yet in the template but can be quick fixed in BF.

@chelsea-lin chelsea-lin merged commit 4221632 into main Sep 18, 2024
@chelsea-lin chelsea-lin deleted the main_chelsealin_chore branch September 18, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants