Skip to content

Conversation

@mukund-ananthu
Copy link
Contributor

  1. Add a code sample to demonstrate creating a Pub/Sub topic with Ingestion Source Settings.
  2. IngestionDataSourceSettings are added as an attribute to the Topic here

Fixes #1119

@mukund-ananthu mukund-ananthu requested review from a team as code owners March 13, 2024 20:37
@mukund-ananthu mukund-ananthu requested a review from nicain March 13, 2024 20:37
@snippet-bot
Copy link

snippet-bot bot commented Mar 13, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Mar 13, 2024
@mukund-ananthu mukund-ananthu self-assigned this Mar 13, 2024
@mukund-ananthu mukund-ananthu added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 13, 2024
@mukund-ananthu mukund-ananthu requested review from parthea and removed request for nicain March 13, 2024 22:13
@parthea parthea changed the title feat: Add Create Topic with Kinesis IngestionDataSourceSettings Sample docs(samples): Add Create Topic with Kinesis IngestionDataSourceSettings Sample Mar 14, 2024
@mukund-ananthu mukund-ananthu merged commit 83dc9ff into main Mar 14, 2024
@mukund-ananthu mukund-ananthu deleted the createTopic branch March 14, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CreateTopic with IngestionDataSourceSettings code sample

3 participants