Skip to content

fix: Expose types.PublisherOptions #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Expose types.PublisherOptions #167

wants to merge 2 commits into from

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Jul 23, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #168 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@ryanyuan ryanyuan force-pushed the expose-typing-publisheroptions branch from 6b55532 to 5b136cf Compare July 23, 2020 02:01
@ryanyuan ryanyuan changed the title Expose pubsub_v1.types.PublisherOptions fix: Expose pubsub_v1.types.PublisherOptions Jul 23, 2020
@ryanyuan ryanyuan closed this Jul 23, 2020
@ryanyuan ryanyuan changed the title fix: Expose pubsub_v1.types.PublisherOptions fix: Expose types.PublisherOptions Jul 23, 2020
@ryanyuan ryanyuan reopened this Jul 23, 2020
@plamut
Copy link
Contributor

plamut commented Jul 23, 2020 •
edited
Loading

@ryanyuan Thanks for the kind fix!

I noticed the same while transitioning the library to the new code generator and will be fixed in the respective PR (also fixes a few other currently missing types).

I'll still keep this open for the time being, just in case the linked PR is significantly delayed due to blockers.

@plamut plamut added the type: docs Improvement to the documentation for an API. label Jul 23, 2020
@ryanyuan
Copy link
Contributor Author

ryanyuan commented Jul 23, 2020

@plamut No problem. Thanks.

@busunkim96 busunkim96 closed this Jul 31, 2020
@plamut plamut reopened this Jul 31, 2020
@anguillanneuf anguillanneuf self-requested a review August 7, 2020 18:07
@plamut
Copy link
Contributor

plamut commented Aug 31, 2020

I'm closing this in favor of #158 which will fix the missing PublisherOptions type in the docs, as well as a few other types, too.

@plamut plamut closed this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PublisherOptions Not Found in API Docs

4 participants

@ryanyuan @plamut @busunkim96 @anguillanneuf