Skip to content

fix: require google-cloud-core >= 1.4.4 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix: require google-cloud-core >= 1.4.4 #1015

merged 1 commit into from
Oct 8, 2023

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Sep 30, 2023

Fixes #1014 🦕

@parthea parthea requested review from a team as code owners September 30, 2023 11:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Sep 30, 2023
@parthea parthea mentioned this pull request Sep 30, 2023
Merged
1 task
harshachinta
harshachinta approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the presubmit checks pass

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Oct 4, 2023

The exception on the presubmit seems to be ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2g 1 Mar 2016'. See: https://github.com/urllib3/urllib3/issues/2168

@parthea

@parthea
Copy link
Contributor Author

parthea commented Oct 7, 2023

I filed #1018 for the presubmit issue

@harshachinta
Copy link
Contributor

harshachinta commented Oct 7, 2023

@parthea
Can this PR be merged or needs to be validated further before merging?
Can you please take necessary action?

@parthea parthea merged commit a2f87b9 into main Oct 8, 2023
@parthea parthea deleted the require-google-cloud-core-1-4-4 branch October 8, 2023 14:22
@release-please release-please bot mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade minimum version of google-cloud-core to 1.4.4

4 participants

@parthea @vchudnov-g @harshachinta