-
Notifications
You must be signed in to change notification settings - Fork 167
Renamed the config-main.toml to config.toml. #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… doesn't generate a valid site, but is the one used by default. Fixes #236
|
are you sure this needs to be done? |
|
ah sorry yes, race condition between mine and your comments (I didn't see yours before this PR). Well I don't see how the prod config choses the config-main.toml over the default. But for completeness I'll get a old hugo and see what it does. But at least something has to be done. Either update the README to say use Hugo 0.15, or tell users to use --config config-main.toml, or this PR. |
|
I haven't tested this, but I would guess that it is the I see no good reason to not use the Hugo default (i.e. |
…stead of layouts-main.
|
Ah I'm going to abandon this... So the reason this works in prod, is because the theme is specified on the command line. If I do the same it works, so it does appear hugo is set up to have two different configurations, a config.toml (using gaweb) and config-main.toml using the theme defined in the layouts-main directory. Coming back I see that #239 is a simple fix to specify the theme in the config, and testing their change it seems to fix my issues. |
| layoutdir = "layouts-main" | ||
| publishdir = "public-main" | ||
| layoutdir = "layouts" | ||
| publishdir = "public" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing those settings entirely. Those are the defaults, and these will never change in Hugo. This also includes the contentDir above.
|
even better just delete the config-main file It's not used anymore and causes way too much confusion. There used to be two sites served from this same repo. |
The original config.toml doesn't generate a valid site, but is the one used by default. Fixes #236