From bb63d08d44f6712d544f66df84362cd8ce31ddac Mon Sep 17 00:00:00 2001 From: Marco Pracucci Date: Fri, 2 Apr 2021 10:54:50 +0200 Subject: [PATCH 1/2] Fixed CortexCompactorRunFailed threshold Signed-off-by: Marco Pracucci --- cortex-mixin/alerts/compactor.libsonnet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cortex-mixin/alerts/compactor.libsonnet b/cortex-mixin/alerts/compactor.libsonnet index a2615e04..c8ac434a 100644 --- a/cortex-mixin/alerts/compactor.libsonnet +++ b/cortex-mixin/alerts/compactor.libsonnet @@ -67,7 +67,7 @@ // Alert if compactor fails. alert: 'CortexCompactorRunFailed', expr: ||| - increase(cortex_compactor_runs_failed_total[2h]) > 1 + increase(cortex_compactor_runs_failed_total[2h]) >= 2 |||, labels: { severity: 'critical', From 0ea97ee113ea8eea2f1d95b8f2d6e629666c6e29 Mon Sep 17 00:00:00 2001 From: Marco Pracucci Date: Fri, 2 Apr 2021 10:56:33 +0200 Subject: [PATCH 2/2] Added CHANGELOG entry Signed-off-by: Marco Pracucci --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74ba509f..639dbc69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ * [ENHANCEMENT] Added `newCompactorStatefulSet()` function to create a custom statefulset for the compactor. #287 * [ENHANCEMENT] Added option to configure compactor job name used in dashboards and alerts. #287 +* [BUGFIX] Fixed `CortexCompactorRunFailed` false positives. #288 ## 1.8.0 / 2021-03-25