This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Extend Alertmanager dashboard with currently unused metrics. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
May 26, 2021
Collaborator
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Very good job! It definitely improves the visibility over the new alertmanager sharding. I left few comments I would be glad if you could take a look.
Thanks!
pracucci
approved these changes
May 27, 2021
Collaborator
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Good job! I left few final nits, but consider it already approved. Please test it in a dev env before merging. Thanks!
stevesg
force-pushed
the
alertmanager-sharding
branch
from
a16eacf to
d998b25
Compare
Metrics for general operation: - Added "Tenants" stat panel using: `cortex_alertmanager_tenants_discovered` - Added "Tenant Configuration Sync" row using: `cortex_alertmanager_sync_configs_failed_total` `cortex_alertmanager_sync_configs_total` `cortex_alertmanager_ring_check_errors_total` Metrics specific to sharding operation: - Added "Sharding Initial State Sync" row using: `cortex_alertmanager_state_initial_sync_completed_total` `cortex_alertmanager_state_initial_sync_completed_total` `cortex_alertmanager_state_initial_sync_duration_seconds` - Added "Sharding State Operations" row using: `cortex_alertmanager_state_fetch_replica_state_total` `cortex_alertmanager_state_fetch_replica_state_failed_total` `cortex_alertmanager_state_replication_total` `cortex_alertmanager_state_replication_failed_total` `cortex_alertmanager_partial_state_merges_total` `cortex_alertmanager_partial_state_merges_failed_total` `cortex_alertmanager_state_persist_total` `cortex_alertmanager_state_persist_failed_total`
stevesg
force-pushed
the
alertmanager-sharding
branch
from
144e088 to
629d288
Compare
Contributor
Author
|
Updated and tested. |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…er-sharding Extend Alertmanager dashboard with currently unused metrics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Metrics for general operation:
Added "Tenants" stat panel using:
cortex_alertmanager_tenants_discoveredAdded "Tenant Configuration Sync" row using:
cortex_alertmanager_sync_configs_failed_totalcortex_alertmanager_sync_configs_totalcortex_alertmanager_ring_check_errors_totalMetrics specific to sharding operation:
Added "Sharding Initial State Sync" row using:
cortex_alertmanager_state_initial_sync_completed_totalcortex_alertmanager_state_initial_sync_completed_totalcortex_alertmanager_state_initial_sync_duration_secondsAdded "Sharding State Operations" row using:
cortex_alertmanager_state_fetch_replica_state_totalcortex_alertmanager_state_fetch_replica_state_failed_totalcortex_alertmanager_state_replication_totalcortex_alertmanager_state_replication_failed_totalcortex_alertmanager_partial_state_merges_totalcortex_alertmanager_partial_state_merges_failed_totalcortex_alertmanager_state_persist_totalcortex_alertmanager_state_persist_failed_totalI did not add a configuration to enable/disable the sharding-specific dashboards as the resulting jsonnet is somewhat messy, but I am happy to add it if deemed necessary.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]