fix(instrumentation): fix native histogram defaults #13465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some native histograms don't have max bucket and reset duration set. This means they could grow very big and reduce resolution without a chance to reset. Use the recommended defaults. Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added
the
changelog-not-needed
narqo
approved these changes
Nov 13, 2025
Contributor
narqo
left a comment
narqo
left a comment
There was a problem hiding this comment.
Native histograms are tricky to hold right, it seems 😞 But the changes overall work for me
| "github.com/prometheus/prometheus/tsdb" | ||
| "github.com/prometheus/prometheus/tsdb/index" | ||
| "github.com/tylertreat/BoomFilters" | ||
| boom "github.com/tylertreat/BoomFilters" |
Contributor
There was a problem hiding this comment.
Did you change this on purpose? It seems a noop for the rest of the file, and looks unrelated 🤔
Contributor
Author
There was a problem hiding this comment.
nope, make format did it, I'll change it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Some native histograms don't have max bucket and reset duration set. This means they could grow very big and reduce resolution without a chance to reset. Use the recommended defaults.
See https://grafana.com/docs/mimir/latest/send/native-histograms/_exponential_buckets/#limit-the-number-of-buckets-in-application-instrumentation
Which issue(s) this PR fixes or relates to
Related to #7154
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Add default
NativeHistogramMaxBucketNumber=100andNativeHistogramMinResetDuration=1hto multiple Prometheus histograms; minor import alias fix for BoomFilters.NativeHistogramMaxBucketNumber=100andNativeHistogramMinResetDuration=1h(keepingNativeHistogramBucketFactor) for:pkg/blockbuilder:consume_job_duration_seconds, TSDB compact/upload duration; schedulerschedule_update_seconds.pkg/ingester:queried_series,discarded_series_ratio.pkg/storage/ingest: pusherprocessing_time_seconds,pusher_*histograms; readerestimated_bytes_per_record,records_batch_*,records_batch_process_duration_seconds; strong consistency wait duration; commit request latency.pkg/streamingpromql: engineestimated_query_peak_memory_consumption; plannerplan_stage_latency_seconds.pkg/usagetracker/usagetrackerclient: clientrequest_duration_seconds.tools/querytee: relative and proportional backend response duration histograms.timewhere needed.boom "github.com/tylertreat/BoomFilters"inlookupplan/stats.go.Written by Cursor Bugbot for commit 11275f6. This will update automatically on new commits. Configure here.