indexer-common,-agent: Various robustness and UX improvements #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cryptovestor21 this PR should resolve the issue you reported on discord of actions being "eagerly" added to the queue just after they were executed successfully. @trader-payne this should help with issues you saw where temporary network/compute issues lead to failed epoch subgraph queries which in turn led to failed unallocate or reallocate actions. |
fordN
force-pushed
the
ford/prevent-duplicate-actions
branch
from
359eee1 to
cc9fee6
Compare
- Do not add action to queue if identical action was recently successful - Do not add action to queue if identical action failed within last 15 minutes - Use retries for epoch subgraph queries (5 attempts) - Improve clarity of code to add offchain subgraphs to targetDeployments - Improve ActionManager.fetchActions - Improve code clarity and logging on failed indexing status query
fordN
force-pushed
the
ford/prevent-duplicate-actions
branch
from
cc9fee6 to
eeb89d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various improvements to code clarity and robustness. Along with some code clarity updates and an added retry loop for epoch subgraph queries, it aims to reduce noise in logs and the action queue by adding a few delays and duplicate action protections.
Changes included
targetDeploymentsActionManager.fetchActions()and include tests for filtering on theupdatedAtfield.