Update 'Field Collection' explanation #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
reviewed
Aug 4, 2020
spec/Section 6 -- Execution.md
Outdated
Comment on lines
454
to
455
| name). This ensures all fields with the same response key including via | ||
| referenced fragments are executed at the same time. |
Member
There was a problem hiding this comment.
Maybe it would be clearer with parenthesis, e.g.:
Suggested change
| name). This ensures all fields with the same response key including via | |
| referenced fragments are executed at the same time. | |
| name). This ensures all fields with the same response key (including those | |
| in referenced fragments) are executed at the same time. |
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion, the PR is updated and is squashed to one single commit.
IvanGoncharov
added
the
✏️ Editorial
Member
|
@benjie Thanks for the review 👍 |
benjie
approved these changes
Aug 21, 2020
Member
|
|
Collaborator
|
@dugenkui03 would you mind making sure the CLA is signed? |
Contributor
Author
@leebyron done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seems to alter the semantic of content, but I think this make semantic to be more accurate.
This ensures all fields with the same response key included via referenced fragments are executed at the same time.
This ensures all fields with the same response key including via referenced fragments are executed at the same time.