Skip to content

Commit 397a253

Browse files
richardcochrandavem330
authored andcommitted
net: dp83640: fix broken calibration routine.
Currently, the calibration function that corrects the initial offsets among multiple devices only works the first time. If the function is called more than once, the calibration fails and bogus offsets will be programmed into the devices. In a well hidden spot, the device documentation tells that trigger indexes 0 and 1 are special in allowing the TRIG_IF_LATE flag to actually work. This patch fixes the issue by using one of the special triggers during the recalibration method. Signed-off-by: Richard Cochran <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 466c5ac commit 397a253

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/phy/dp83640.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
#define PSF_TX 0x1000
4848
#define EXT_EVENT 1
4949
#define CAL_EVENT 7
50-
#define CAL_TRIGGER 7
50+
#define CAL_TRIGGER 1
5151
#define DP83640_N_PINS 12
5252

5353
#define MII_DP83640_MICR 0x11

0 commit comments

Comments
 (0)