Skip to content

Commit 7660388

Browse files
NeilBrownshligit
authored andcommitted
md/raid0: replace printk() with pr_*()
This makes md/raid0 much less verbose as the messages about the array geometry are now pr_debug() Signed-off-by: NeilBrown <[email protected]> Signed-off-by: Shaohua Li <[email protected]>
1 parent 7279694 commit 7660388

File tree

1 file changed

+44
-45
lines changed

1 file changed

+44
-45
lines changed

drivers/md/raid0.c

Lines changed: 44 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -51,20 +51,21 @@ static void dump_zones(struct mddev *mddev)
5151
char b[BDEVNAME_SIZE];
5252
struct r0conf *conf = mddev->private;
5353
int raid_disks = conf->strip_zone[0].nb_dev;
54-
printk(KERN_INFO "md: RAID0 configuration for %s - %d zone%s\n",
55-
mdname(mddev),
56-
conf->nr_strip_zones, conf->nr_strip_zones==1?"":"s");
54+
pr_debug("md: RAID0 configuration for %s - %d zone%s\n",
55+
mdname(mddev),
56+
conf->nr_strip_zones, conf->nr_strip_zones==1?"":"s");
5757
for (j = 0; j < conf->nr_strip_zones; j++) {
58-
printk(KERN_INFO "md: zone%d=[", j);
58+
char line[200];
59+
int len = 0;
60+
5961
for (k = 0; k < conf->strip_zone[j].nb_dev; k++)
60-
printk(KERN_CONT "%s%s", k?"/":"",
61-
bdevname(conf->devlist[j*raid_disks
62-
+ k]->bdev, b));
63-
printk(KERN_CONT "]\n");
62+
len += snprintf(line+len, 200-len, "%s%s", k?"/":"",
63+
bdevname(conf->devlist[j*raid_disks
64+
+ k]->bdev, b));
65+
pr_debug("md: zone%d=[%s]\n", j, line);
6466

6567
zone_size = conf->strip_zone[j].zone_end - zone_start;
66-
printk(KERN_INFO " zone-offset=%10lluKB, "
67-
"device-offset=%10lluKB, size=%10lluKB\n",
68+
pr_debug(" zone-offset=%10lluKB, device-offset=%10lluKB, size=%10lluKB\n",
6869
(unsigned long long)zone_start>>1,
6970
(unsigned long long)conf->strip_zone[j].dev_start>>1,
7071
(unsigned long long)zone_size>>1);
@@ -142,9 +143,9 @@ static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf)
142143
* chunk size is a multiple of that sector size
143144
*/
144145
if ((mddev->chunk_sectors << 9) % blksize) {
145-
printk(KERN_ERR "md/raid0:%s: chunk_size of %d not multiple of block size %d\n",
146-
mdname(mddev),
147-
mddev->chunk_sectors << 9, blksize);
146+
pr_warn("md/raid0:%s: chunk_size of %d not multiple of block size %d\n",
147+
mdname(mddev),
148+
mddev->chunk_sectors << 9, blksize);
148149
err = -EINVAL;
149150
goto abort;
150151
}
@@ -186,19 +187,18 @@ static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf)
186187
}
187188

188189
if (j < 0) {
189-
printk(KERN_ERR
190-
"md/raid0:%s: remove inactive devices before converting to RAID0\n",
191-
mdname(mddev));
190+
pr_warn("md/raid0:%s: remove inactive devices before converting to RAID0\n",
191+
mdname(mddev));
192192
goto abort;
193193
}
194194
if (j >= mddev->raid_disks) {
195-
printk(KERN_ERR "md/raid0:%s: bad disk number %d - "
196-
"aborting!\n", mdname(mddev), j);
195+
pr_warn("md/raid0:%s: bad disk number %d - aborting!\n",
196+
mdname(mddev), j);
197197
goto abort;
198198
}
199199
if (dev[j]) {
200-
printk(KERN_ERR "md/raid0:%s: multiple devices for %d - "
201-
"aborting!\n", mdname(mddev), j);
200+
pr_warn("md/raid0:%s: multiple devices for %d - aborting!\n",
201+
mdname(mddev), j);
202202
goto abort;
203203
}
204204
dev[j] = rdev1;
@@ -208,8 +208,8 @@ static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf)
208208
cnt++;
209209
}
210210
if (cnt != mddev->raid_disks) {
211-
printk(KERN_ERR "md/raid0:%s: too few disks (%d of %d) - "
212-
"aborting!\n", mdname(mddev), cnt, mddev->raid_disks);
211+
pr_warn("md/raid0:%s: too few disks (%d of %d) - aborting!\n",
212+
mdname(mddev), cnt, mddev->raid_disks);
213213
goto abort;
214214
}
215215
zone->nb_dev = cnt;
@@ -357,8 +357,7 @@ static int raid0_run(struct mddev *mddev)
357357
int ret;
358358

359359
if (mddev->chunk_sectors == 0) {
360-
printk(KERN_ERR "md/raid0:%s: chunk size must be set.\n",
361-
mdname(mddev));
360+
pr_warn("md/raid0:%s: chunk size must be set.\n", mdname(mddev));
362361
return -EINVAL;
363362
}
364363
if (md_check_no_bitmap(mddev))
@@ -399,9 +398,9 @@ static int raid0_run(struct mddev *mddev)
399398
/* calculate array device size */
400399
md_set_array_sectors(mddev, raid0_size(mddev, 0, 0));
401400

402-
printk(KERN_INFO "md/raid0:%s: md_size is %llu sectors.\n",
403-
mdname(mddev),
404-
(unsigned long long)mddev->array_sectors);
401+
pr_debug("md/raid0:%s: md_size is %llu sectors.\n",
402+
mdname(mddev),
403+
(unsigned long long)mddev->array_sectors);
405404

406405
if (mddev->queue) {
407406
/* calculate the max read-ahead size.
@@ -509,17 +508,17 @@ static void *raid0_takeover_raid45(struct mddev *mddev)
509508
struct r0conf *priv_conf;
510509

511510
if (mddev->degraded != 1) {
512-
printk(KERN_ERR "md/raid0:%s: raid5 must be degraded! Degraded disks: %d\n",
513-
mdname(mddev),
514-
mddev->degraded);
511+
pr_warn("md/raid0:%s: raid5 must be degraded! Degraded disks: %d\n",
512+
mdname(mddev),
513+
mddev->degraded);
515514
return ERR_PTR(-EINVAL);
516515
}
517516

518517
rdev_for_each(rdev, mddev) {
519518
/* check slot number for a disk */
520519
if (rdev->raid_disk == mddev->raid_disks-1) {
521-
printk(KERN_ERR "md/raid0:%s: raid5 must have missing parity disk!\n",
522-
mdname(mddev));
520+
pr_warn("md/raid0:%s: raid5 must have missing parity disk!\n",
521+
mdname(mddev));
523522
return ERR_PTR(-EINVAL);
524523
}
525524
rdev->sectors = mddev->dev_sectors;
@@ -549,19 +548,19 @@ static void *raid0_takeover_raid10(struct mddev *mddev)
549548
* - all mirrors must be already degraded
550549
*/
551550
if (mddev->layout != ((1 << 8) + 2)) {
552-
printk(KERN_ERR "md/raid0:%s:: Raid0 cannot takeover layout: 0x%x\n",
553-
mdname(mddev),
554-
mddev->layout);
551+
pr_warn("md/raid0:%s:: Raid0 cannot takeover layout: 0x%x\n",
552+
mdname(mddev),
553+
mddev->layout);
555554
return ERR_PTR(-EINVAL);
556555
}
557556
if (mddev->raid_disks & 1) {
558-
printk(KERN_ERR "md/raid0:%s: Raid0 cannot takeover Raid10 with odd disk number.\n",
559-
mdname(mddev));
557+
pr_warn("md/raid0:%s: Raid0 cannot takeover Raid10 with odd disk number.\n",
558+
mdname(mddev));
560559
return ERR_PTR(-EINVAL);
561560
}
562561
if (mddev->degraded != (mddev->raid_disks>>1)) {
563-
printk(KERN_ERR "md/raid0:%s: All mirrors must be already degraded!\n",
564-
mdname(mddev));
562+
pr_warn("md/raid0:%s: All mirrors must be already degraded!\n",
563+
mdname(mddev));
565564
return ERR_PTR(-EINVAL);
566565
}
567566

@@ -588,7 +587,7 @@ static void *raid0_takeover_raid1(struct mddev *mddev)
588587
* - (N - 1) mirror drives must be already faulty
589588
*/
590589
if ((mddev->raid_disks - 1) != mddev->degraded) {
591-
printk(KERN_ERR "md/raid0:%s: (N - 1) mirrors drives must be already faulty!\n",
590+
pr_err("md/raid0:%s: (N - 1) mirrors drives must be already faulty!\n",
592591
mdname(mddev));
593592
return ERR_PTR(-EINVAL);
594593
}
@@ -631,8 +630,8 @@ static void *raid0_takeover(struct mddev *mddev)
631630
*/
632631

633632
if (mddev->bitmap) {
634-
printk(KERN_ERR "md/raid0: %s: cannot takeover array with bitmap\n",
635-
mdname(mddev));
633+
pr_warn("md/raid0: %s: cannot takeover array with bitmap\n",
634+
mdname(mddev));
636635
return ERR_PTR(-EBUSY);
637636
}
638637
if (mddev->level == 4)
@@ -642,8 +641,8 @@ static void *raid0_takeover(struct mddev *mddev)
642641
if (mddev->layout == ALGORITHM_PARITY_N)
643642
return raid0_takeover_raid45(mddev);
644643

645-
printk(KERN_ERR "md/raid0:%s: Raid can only takeover Raid5 with layout: %d\n",
646-
mdname(mddev), ALGORITHM_PARITY_N);
644+
pr_warn("md/raid0:%s: Raid can only takeover Raid5 with layout: %d\n",
645+
mdname(mddev), ALGORITHM_PARITY_N);
647646
}
648647

649648
if (mddev->level == 10)
@@ -652,7 +651,7 @@ static void *raid0_takeover(struct mddev *mddev)
652651
if (mddev->level == 1)
653652
return raid0_takeover_raid1(mddev);
654653

655-
printk(KERN_ERR "Takeover from raid%i to raid0 not supported\n",
654+
pr_warn("Takeover from raid%i to raid0 not supported\n",
656655
mddev->level);
657656

658657
return ERR_PTR(-EINVAL);

0 commit comments

Comments
 (0)