Use object for Top / Left / Bottom / Right in MarginOptions #2788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
PDFMarginusesstring | numberPDFOptions.Width/PDFOptions.Heightalso usestring | numberupstreamPdfOptions.Width/PdfOptions.Heightusingobjectpuppeteer-sharp/lib/PuppeteerSharp/PdfOptions.cs
Lines 67 to 75 in e14f59d
ConvertPrintParameterToInchespuppeteer-sharp/lib/PuppeteerSharp/Cdp/CdpPage.cs
Lines 791 to 807 in e14f59d
PdfOptionsShouldBeSerializabledidn't actually testWidth/Heightwhich meant that serialisation was broken by the migration toSystem.Text.Json.I added a simple
PrimitiveTypeConverterto support #1001PdfOptionsShouldWorkWithMarginWithNoUnitsdidn't actually test theConvertPrintParameterToIncheslogic so I have removed it. It was just testing whatPdfOptionsShouldBeSerializablealready did.Also made
MarginOptions/PaperFormatrecords.