Skip to content

Commit e7a921d

Browse files
committed
setting up rendering tests correctly
1 parent 4de398e commit e7a921d

File tree

160 files changed

+168
-171
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

160 files changed

+168
-171
lines changed

showcase/app/templates/components/accordion.hbs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55

66
{{page-title "Accordion Component"}}
77

8-
<Shw::Text::H1>Accordion</Shw::Text::H1>
8+
<Shw::Text::H1>
9+
{{t "showcase.components.accordion.component_name"}}
10+
</Shw::Text::H1>
911

1012
<section data-test-percy>
1113

showcase/tests/helpers/index.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import {
99
setupTest as upstreamSetupTest,
1010
type SetupTestOptions,
1111
} from 'ember-qunit';
12-
13-
import { setupIntlRenderingTest } from './setup-intl-rendering-test';
12+
import { setupIntl } from 'ember-intl/test-support';
1413

1514
// This file exists to provide wrappers around ember-qunit's
1615
// test setup functions. This way, you can easily extend the setup that is
@@ -31,14 +30,14 @@ function setupApplicationTest(hooks: NestedHooks, options?: SetupTestOptions) {
3130
// This is also a good place to call test setup functions coming
3231
// from other addons:
3332
//
34-
// setupIntl(hooks, 'en-us'); // ember-intl
33+
setupIntl(hooks, 'en-us'); // ember-intl
3534
// setupMirage(hooks); // ember-cli-mirage
3635
}
3736

3837
function setupRenderingTest(hooks: NestedHooks, options?: SetupTestOptions) {
3938
upstreamSetupRenderingTest(hooks, options);
4039

41-
setupIntlRenderingTest(hooks, 'en-us');
40+
setupIntl(hooks, 'en-us');
4241

4342
// Additional setup for rendering tests can be done here.
4443
}

showcase/tests/helpers/setup-intl-rendering-test.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

showcase/tests/integration/components/hds/accordion/index-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { click, render } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

showcase/tests/integration/components/hds/advanced-table/index-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render, click, focus, setupOnerror } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010
import sinon from 'sinon';

showcase/tests/integration/components/hds/advanced-table/td-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

showcase/tests/integration/components/hds/advanced-table/th-sort-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render, click, focus, setupOnerror } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

showcase/tests/integration/components/hds/advanced-table/th-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render, focus, click, setupOnerror } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

showcase/tests/integration/components/hds/advanced-table/tr-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render, click, setupOnerror } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

showcase/tests/integration/components/hds/alert/index-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { module, test } from 'qunit';
7-
import { setupRenderingTest } from 'ember-qunit';
7+
import { setupRenderingTest } from 'showcase/tests/helpers';
88
import { render, resetOnerror, setupOnerror } from '@ember/test-helpers';
99
import { hbs } from 'ember-cli-htmlbars';
1010

0 commit comments

Comments
 (0)