-
Notifications
You must be signed in to change notification settings - Fork 51
🧪 [Spike] Get theming “support” in the Showcase app - First scrappy iteration #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The first iteration (this one) is now outdated (we're working in the branch |
aklkv
reviewed
Dec 15, 2024
| export default class ShwThemeSwitcher extends Component<ShwThemeSwitcherSignature> { | ||
| @service declare readonly theming: ShwThemingService; | ||
|
|
||
| @action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in .gts files @action can be replaced with an arrow function
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE 🚨
📌 Summary
Branch used for exploring what needs to be done to have "support" for theming in the Showcase app.
shw-color)In the process, we will use the Showcase app as proxy to a real “consumer” (Product) Ember app, to understand
Later, the showcase will be used to test the HDS theming itself.
🔗 External links
Jira tickets: