Skip to content

Conversation

@dchyun
Copy link
Contributor

@dchyun dchyun commented Jul 15, 2025

πŸ“Œ Summary

If merged, this PR would follow up on the work in #3004 to make some alignments to other showcase TS patterns, and address feedback from that PR.

πŸ› οΈ Detailed description

Changes made to the utilities pages in this PR

  • Added a model to the DismissButton route to align to the pattern used in other files
  • Updated the toggleState function in the DisclosurePrimitive controller
  • Added a comment in the PopoverPrimitive template pointing to the JIRA ticket for a potential future update

πŸ”— External links

Jira ticket: HDS-5076


πŸ‘€ Component checklist

  • Percy was checked for any visual regression

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jul 15, 2025 2:46pm
hds-website βœ… Ready (Inspect) Visit Preview Jul 15, 2025 2:46pm

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@dchyun dchyun merged commit 60fcd5b into main Jul 15, 2025
16 checks passed
@dchyun dchyun deleted the dchyun/showcase-utilities-alignments branch July 15, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants