Skip to content

HdsDropdownListItemInteractive - Remove deprecated @text argument #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 1, 2025
Merged

HdsDropdownListItemInteractive - Remove deprecated @text argument #3212

merged 7 commits into from
Oct 1, 2025

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 19, 2025 •
edited by atlassian bot
Loading

📌 Summary

If merged, this PR removed the deprecated @text argument from the HdsDropdownListItemInteractive component.

🔗 External links

Jira ticket: HDS-5506

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@zamoore zamoore requested a review from a team as a code owner September 19, 2025 19:33
@vercel
Copy link

vercel bot commented Sep 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 1, 2025 1:23am
hds-website Ready Ready Preview Oct 1, 2025 1:23am

@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from ec759cb to 441813d Compare September 19, 2025 19:33
@zamoore zamoore requested a review from a team as a code owner September 22, 2025 14:53
@zamoore zamoore force-pushed the main-5.0.0 branch 4 times, most recently from 468a8bc to 79d8cc2 Compare September 23, 2025 12:59
@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from 342b659 to 98908e6 Compare September 23, 2025 13:01
@zamoore zamoore changed the title Zamoore/hds 5506/hds dropdown list item interactive remove text HdsDropdownListItemInteractive - Remove deprecated @text argument Sep 23, 2025
didoo
didoo reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the integration tests need to be updated

(the documentation will be updated in a separate branch/PR? I saw another PR where it was done in the same branch)

@zamoore zamoore force-pushed the main-5.0.0 branch 2 times, most recently from 81d8152 to 8c88fcd Compare September 24, 2025 18:29
@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from 98908e6 to 885957f Compare September 24, 2025 19:10
@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Sep 24, 2025
@zamoore
Copy link
Contributor Author

zamoore commented Sep 24, 2025

the integration tests need to be updated

(the documentation will be updated in a separate branch/PR? I saw another PR where it was done in the same branch)

all set now

@zamoore zamoore requested a review from didoo September 24, 2025 19:59
alex-ju
alex-ju reviewed Sep 25, 2025
View reviewed changes
@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from a635ad1 to 80489cf Compare September 30, 2025 21:33
@zamoore zamoore merged commit 708ecef into main-5.0.0 Oct 1, 2025
22 of 23 checks passed
@zamoore zamoore deleted the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch October 1, 2025 01:52
@zamoore zamoore mentioned this pull request Oct 1, 2025
Draft
5 tasks
zamoore added a commit that referenced this pull request Oct 1, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
093887b 
…#3212)
zamoore added a commit that referenced this pull request Oct 2, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
75b7fd8 
…#3212)
zamoore added a commit that referenced this pull request Oct 3, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
61fc3dc 
…#3212)
zamoore added a commit that referenced this pull request Oct 3, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
cfa864b 
…#3212)
zamoore added a commit that referenced this pull request Oct 6, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
e36476e 
…#3212)
zamoore added a commit that referenced this pull request Oct 7, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
053bbf0 
…#3212)
zamoore added a commit that referenced this pull request Oct 7, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
05018a7 
…#3212)
zamoore added a commit that referenced this pull request Oct 8, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
3b5093e 
…#3212)
zamoore added a commit that referenced this pull request Oct 9, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
3ce4be5 
…#3212)
zamoore added a commit that referenced this pull request Oct 10, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
5857fe8 
…#3212)
zamoore added a commit that referenced this pull request Oct 10, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
2c62a4e 
…#3212)
zamoore added a commit that referenced this pull request Oct 13, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
b8f0117 
…#3212)
zamoore added a commit that referenced this pull request Oct 14, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
79393b0 
…#3212)
zamoore added a commit that referenced this pull request Oct 27, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
7a7f119 
…#3212)
zamoore added a commit that referenced this pull request Oct 27, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
abb9ba8 
…#3212)
zamoore added a commit that referenced this pull request Oct 28, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
7677374 
…#3212)
zamoore added a commit that referenced this pull request Oct 31, 2025
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
a041cf9 
…#3212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-ju alex-ju alex-ju left review comments

@didoo didoo didoo approved these changes

Assignees

No one assigned

Labels

docs-website Content updates to the documentation website packages/components showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zamoore @didoo @alex-ju @hashibot-hds