changelogs for Cabal-3.14 and (incomplete) cabal-install-3.16 #10322
Conversation
If a changelog entry mentions two packages, then both packages' changelogs have an individual entry. Ideally PRs would have 1 changelog entry per package. Of course for packages that share the same changelog (cabal-install and cabal-install-solvers, Cabal and Cabal-syntax), the question is not relevant. |
|
All right, then it is not an issue, I guess. I'll solve the whitespace problem, but in the meantime, some eyeballing of the files would be helpful |
| consumed by other `Hooks` clients (e.g. eventually HLS). | ||
|
|
||
| - Bug fix - Don't pass --coverage-for for non-dependency libs of testsuite [#10046](https://github.com/haskell/cabal/issues/10046) [#10250](https://github.com/haskell/cabal/pull/10250) | ||
| - Added `--all` and `--haddock-all` switches to `haddock-project` subcommand [#10051](https://github.com/haskell/cabal/issues/10051) [#2272](https://github.com/haskell/cabal/pull/2272) |
There was a problem hiding this comment.
Wow, great catch!
One PR but different commits seems ok. |
|
For the warnings, let's summon @fgaz |
| - Neutral field to add files to sdist [#8817](https://github.com/haskell/cabal/issues/8817) [#10107](https://github.com/haskell/cabal/pull/10107) | ||
|
|
||
| Adds the `extra-files` field to the cabal file specification. This is like | ||
| the other `extra-*` fields in that it is copied with the `sdist` command, | ||
| except there are no other semantics. Compare to: |
There was a problem hiding this comment.
Mhh this seems duplicated (see top-of-file).
There was a problem hiding this comment.
Good catch. I'm guessing it's because the changes for Cabal and Cabal-syntax get appendent. I should properly merge the sections...
There was a problem hiding this comment.
I am not sure they do (or they should do), once the Swedish Francesco is here we can confirm.
There was a problem hiding this comment.
it's not about changelog-d itself, it's about how we use it. The wiki says:
$ changelog-d --long --package Cabal --prlog 3.10.3.0.prlog >> Cabal.changes
$ changelog-d --long --package Cabal-syntax --prlog 3.10.3.0.prlog >> Cabal.changes
|
I made a grieve mistake by naming the branch 3.14-blah -- it falls under the protected branches that way. I'll have to redo the PR... |
|
#10323 moving here |
I added a WIP changelog for the tool which is easier, I think: we just remove all the tiny changelog files and at 3.16 will generate and append an update for this WIP (and it becomes the final
release-notes/cabal-install-3.16...md).Some doubts I have:
I got a bunch of messages from changelog-d, which I don't understand: https://gist.github.com/ulysses4ever/881571e08f0fff4f8dc4d63880d4e52f
I'm not sure about deduplication: should one change touching Cabal and cabal-install be mentioned in both changelogs?Wiki says that a PR removing the little changelog files should go separately, why is that? Why not one PR?
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
[ ] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).