test: run pylint against test files (#592)

This should help us write better tests and catch invalid tests.

Author: jooola

Makefile

@@ -7,6 +7,7 @@ venv:
 
 lint: venv
 	venv/bin/pylint hcloud
+	venv/bin/pylint tests --disable=missing-function-docstring,use-dict-literal,protected-access,redefined-outer-name,unnecessary-dunder-call
 	venv/bin/mypy hcloud
 
 test: venv

tests/unit/actions/test_domain.py

@@ -20,7 +20,7 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)
 
 
 class TestAction:

tests/unit/certificates/test_domain.py

@@ -21,7 +21,7 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)
 
 
 class TestCertificate:

tests/unit/core/test_client.py

@@ -47,7 +47,7 @@ def test_get_non_exists_model_attribute_complete_model(
             client=client, data={"id": 1, "name": "name", "description": "description"}
         )
         with pytest.raises(AttributeError):
-            bound_model.content
+            _ = bound_model.content
         client.get_by_id.assert_not_called()
 
     def test_get_exists_model_attribute_incomplete_model(
@@ -77,7 +77,7 @@ def test_get_non_exists_model_attribute_incomplete_model(
     ):
         bound_model = bound_model_class(client=client, data={"id": 1}, complete=False)
         with pytest.raises(AttributeError):
-            bound_model.content
+            _ = bound_model.content
         client.get_by_id.assert_not_called()
         assert bound_model.complete is False
 
@@ -137,7 +137,7 @@ def get_actions_list(self, status, page=None, per_page=None):
     def test_iter_pages_no_meta(self, client_class_constructor):
         json_content = {"candies": [1, 2]}
 
-        def json_content_function(p):
+        def json_content_function(_):
             return json_content
 
         candies_client = client_class_constructor(json_content_function)
@@ -152,7 +152,7 @@ def test_iter_pages_no_next_page(self, client_class_constructor):
             "meta": {"pagination": {"page": 1, "per_page": 11, "next_page": None}},
         }
 
-        def json_content_function(p):
+        def json_content_function(_):
             return json_content
 
         candies_client = client_class_constructor(json_content_function)
@@ -218,7 +218,7 @@ def json_content_function(p):
     def test_get_first_by_result_exists(self, client_class_constructor):
         json_content = {"candies": [1]}
 
-        def json_content_function(p):
+        def json_content_function(_):
             return json_content
 
         candies_client = client_class_constructor(json_content_function)
@@ -230,7 +230,7 @@ def json_content_function(p):
     def test_get_first_by_result_does_not_exist(self, client_class_constructor):
         json_content = {"candies": []}
 
-        def json_content_function(p):
+        def json_content_function(_):
             return json_content
 
         candies_client = client_class_constructor(json_content_function)

tests/unit/datacenters/test_domain.py

@@ -13,4 +13,4 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)

tests/unit/deprecation/test_domain.py

@@ -12,4 +12,4 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)

tests/unit/exp/test_zone.py

@@ -17,8 +17,8 @@ def test_is_txt_record_quoted(value: str, expected: bool):
     assert is_txt_record_quoted(value) == expected
 
 
-manyA = "a" * 255
-someB = "b" * 10
+MANY_A = "a" * 255
+SOME_B = "b" * 10
 
 
 @pytest.mark.parametrize(
@@ -30,7 +30,7 @@ def test_is_txt_record_quoted(value: str, expected: bool):
         ("hello\nworld", '"hello\nworld"'),
         ('hello "world"', '"hello \\"world\\""'),
         ('hello "world', '"hello \\"world"'),
-        (manyA + someB, f'"{manyA}" "{someB}"'),
+        (MANY_A + SOME_B, f'"{MANY_A}" "{SOME_B}"'),
     ],
 )
 def test_format_txt_record(value: str, expected: str):

tests/unit/firewalls/test_domain.py

@@ -25,7 +25,7 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)
 
 
 class TestFirewall:

tests/unit/floating_ips/test_client.py

@@ -228,14 +228,10 @@ def test_create_with_server(
         assert bound_floating_ip.description == "Web Frontend"
         assert action.id == 13
 
-    @pytest.mark.parametrize(
-        "server", [Server(id=1), BoundServer(mock.MagicMock(), dict(id=1))]
-    )
     def test_create_with_name(
         self,
         request_mock: mock.MagicMock,
         floating_ips_client: FloatingIPsClient,
-        server,
         floating_ip_create_response,
     ):
         request_mock.return_value = floating_ip_create_response

tests/unit/floating_ips/test_domain.py

@@ -15,12 +15,12 @@
     ],
 )
 def test_eq(value):
-    assert value == value
+    assert value.__eq__(value)
 
 
 class TestFloatingIP:
     def test_created_is_datetime(self):
-        floatingIP = FloatingIP(id=1, created="2016-01-30T23:50+00:00")
-        assert floatingIP.created == datetime.datetime(
+        floating_ip = FloatingIP(id=1, created="2016-01-30T23:50+00:00")
+        assert floating_ip.created == datetime.datetime(
             2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )