Get pubkey from structured data #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting up the
sign-messagescript for aibtcdev/agent-tools-ts, we ran into an issue where we could not pass the typeStructuredDataSignatureto either of thegetPublicKeyFromSignaturemethods.After experimenting with this it was working in our initial tests, so we added the updated code back with a test to confirm it.
Breaking change?
More like an unblocking change 😉
Example
You can now pass either
MessageSignature | StructuredDataSignatureto the getPublicKeyFromSignature method, detailed example is in the test file.Checklist