Skip to content

Commit 86639da

Browse files
linxiuleihoskeri
authored andcommitted
Allow specifying timeout second for HTTP2/2 health check
The env vars were implemented in kubernetes#95981. Effectively no impacts if using the default values here. BUG=255296578 Change-Id: I2441ef1a181a0fb202af7893c25cff5ff15ef17a Remove GODEBUG=x509sha1=1 workaround Bug: 227456358a Revert changes made in I5165e6c2fe73e8e1b2a617ced591133228b6d275 Change-Id: I7dd1ca8f9796c542c89074703e44e6b6f4b6edab
1 parent 29ac33e commit 86639da

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

gke/cluster/gce/gci/configure-kubeapiserver.sh

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -344,21 +344,17 @@ function start-kube-apiserver {
344344
fi
345345

346346
local container_env=""
347+
348+
# b/255296578
349+
container_env+="{\"name\": \"HTTP2_READ_IDLE_TIMEOUT_SECONDS\", \"value\": \"${KUBE_APISERVER_HTTP2_READ_IDLE_TIMEOUT_SECONDS:-30}\"}"
350+
container_env+=",{\"name\": \"HTTP2_PING_TIMEOUT_SECONDS\", \"value\": \"${KUBE_APISERVER_HTTP2_PING_TIMEOUT_SECONDS:-15}\"}"
351+
347352
if [[ -n "${ENABLE_CACHE_MUTATION_DETECTOR:-}" ]]; then
348-
container_env+="{\"name\": \"KUBE_CACHE_MUTATION_DETECTOR\", \"value\": \"${ENABLE_CACHE_MUTATION_DETECTOR}\"}"
353+
container_env+=",{\"name\": \"KUBE_CACHE_MUTATION_DETECTOR\", \"value\": \"${ENABLE_CACHE_MUTATION_DETECTOR}\"}"
349354
fi
350355
if [[ -n "${ENABLE_PATCH_CONVERSION_DETECTOR:-}" ]]; then
351-
if [[ -n "${container_env}" ]]; then
352-
container_env="${container_env}, "
353-
fi
354-
container_env+="{\"name\": \"KUBE_PATCH_CONVERSION_DETECTOR\", \"value\": \"${ENABLE_PATCH_CONVERSION_DETECTOR}\"}"
355-
fi
356-
357-
# b/227456358
358-
if [[ -n "${container_env}" ]]; then
359-
container_env="${container_env}, "
356+
container_env+=",{\"name\": \"KUBE_PATCH_CONVERSION_DETECTOR\", \"value\": \"${ENABLE_PATCH_CONVERSION_DETECTOR}\"}"
360357
fi
361-
container_env+='{"name": "GODEBUG", "value": "x509sha1=1"}'
362358

363359
if [[ -n "${container_env}" ]]; then
364360
container_env="\"env\":[${container_env}],"

0 commit comments

Comments
 (0)