make it non breaking

Author: mib1185

pyfritzhome/fritzhome.py

@@ -154,7 +154,7 @@ def get_prefixed_host(self):
         else:
             return "http://" + host
 
-    def update_devices(self):
+    def update_devices(self, ignore_removed = True):
         """Update the device."""
         _LOGGER.info("Updating Devices ...")
         if self._devices is None:
@@ -172,12 +172,13 @@ def update_devices(self):
                 device = FritzhomeDevice(self, node=element)
                 self._devices[device.ain] = device
 
-        for identifier in list(self._devices.keys()):
-            if identifier not in [
-                element.attrib["identifier"] for element in device_elements
-            ]:
-                _LOGGER.info("Removing no more existing device " + identifier)
-                self._devices.pop(identifier)
+        if not ignore_removed:
+            for identifier in list(self._devices.keys()):
+                if identifier not in [
+                    element.attrib["identifier"] for element in device_elements
+                ]:
+                    _LOGGER.info("Removing no more existing device " + identifier)
+                    self._devices.pop(identifier)
 
         return True
 
@@ -400,7 +401,7 @@ def has_templates(self):
             return False
         return True
 
-    def update_templates(self):
+    def update_templates(self, ignore_removed = True):
         """Update the template."""
         _LOGGER.info("Updating Templates ...")
         if self._templates is None:
@@ -418,12 +419,13 @@ def update_templates(self):
                 template = FritzhomeTemplate(self, node=element)
                 self._templates[template.ain] = template
 
-        for identifier in list(self._templates.keys()):
-            if identifier not in [
-                element.attrib["identifier"] for element in template_elements
-            ]:
-                _LOGGER.info("Removing no more existing template " + identifier)
-                self._templates.pop(identifier)
+        if not ignore_removed:
+            for identifier in list(self._templates.keys()):
+                if identifier not in [
+                    element.attrib["identifier"] for element in template_elements
+                ]:
+                    _LOGGER.info("Removing no more existing template " + identifier)
+                    self._templates.pop(identifier)
 
         return True
 

tests/test_fritzhomedevicebase.py

@@ -101,11 +101,14 @@ def test_device_removed(self):
         self.mock.side_effect = [
             Helper.response("base/device_list"),
             Helper.response("base/device_list_removed_device"),
+            Helper.response("base/device_list_removed_device"),
         ]
 
         self.fritz.update_devices()
         assert len(self.fritz.get_devices()) == 5
         self.fritz.update_devices()
+        assert len(self.fritz.get_devices()) == 5
+        self.fritz.update_devices(ignore_removed=False)
         assert len(self.fritz.get_devices()) == 4
 
     def test_device_and_unit_id(self):

tests/test_fritzhometemplate.py

@@ -43,13 +43,17 @@ def test_template_removed(self):
         self.mock.side_effect = [
             Helper.response("templates/template_list"),
             Helper.response("templates/template_list_removed_template"),
+            Helper.response("templates/template_list_removed_template"),
         ]
 
         self.fritz.update_templates()
         assert len(self.fritz.get_templates()) == 12
         self.fritz.update_templates()
+        assert len(self.fritz.get_templates()) == 12
+        self.fritz.update_templates(ignore_removed=False)
         assert len(self.fritz.get_templates()) == 11
 
+
     def test_template_with_single_device(self):
         template = self.fritz.get_template_by_ain("tmp0B32F7-1B0650234")