review comments

Author: akshaysngupta

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/ApplicationGatewayTests.ps1

@@ -12,6 +12,24 @@
 # limitations under the License.
 # ----------------------------------------------------------------------------------
 
+function Test-AvailableSslOptions
+{
+	$result = Get-AzureRmApplicationGatewayAvailableWafRuleSets
+
+	Assert-NotNull $result
+	Assert-NotNull $result.Value
+	Assert-True { $result.Value.Count -gt 0 }
+	Assert-NotNull $result.Value[0].Name
+	Assert-NotNull $result.Value[0].RuleSetType
+	Assert-NotNull $result.Value[0].RuleSetVersion
+	Assert-NotNull $result.Value[0].RuleGroups
+	Assert-True { $result.Value[0].RuleGroups.Count -gt 0 }
+	Assert-NotNull $result.Value[0].RuleGroups[0].RuleGroupName
+	Assert-NotNull $result.Value[0].RuleGroups[0].Rules
+	Assert-True { $result.Value[0].RuleGroups[0].Rules.Count -gt 0 }
+	Assert-NotNull $result.Value[0].RuleGroups[0].Rules[0].RuleId
+}
+
 function Test-AvailableWafRuleSets
 {
 	$result = Get-AzureRmApplicationGatewayAvailableWafRuleSets
@@ -374,4 +392,5 @@ function Compare-AzureRmApplicationGateway($expected, $actual)
 
 	Assert-AreEqual $expected.HttpListeners.Count $actual.HttpListeners.Count
 	Assert-AreEqual $expected.RequestRoutingRules.Count $actual.RequestRoutingRules.Count
+	Assert-AreEqual $expected.RedirectConfigurations.Count $actual.RedirectConfigurations.Count
 }

src/ResourceManager/Network/Commands.Network/ApplicationGateway/GetAzureApplicationGatewayAvailableSslOptions.cs

@@ -32,7 +32,7 @@ public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
 
-            var availableSslOptions = this.ApplicationGatewayClient.AvailableSslOptions();
+            var availableSslOptions = this.ApplicationGatewayClient.ListAvailableSslOptions();
             var psAvailableSslOptions = Mapper.Map<PSApplicationGatewayAvailableSslOptions>(availableSslOptions);
             WriteObject(psAvailableSslOptions);
         }

src/ResourceManager/Network/Commands.Network/ApplicationGateway/GetAzureApplicationGatewaySslPredefinedPolicy.cs renamed to src/ResourceManager/Network/Commands.Network/ApplicationGateway/ListAzureApplicationGatewaySslPredefinedPolicy.cs

@@ -22,7 +22,7 @@ namespace Microsoft.Azure.Commands.Network
 
     [Cmdlet(VerbsCommon.Get, "AzureRmApplicationGatewaySslPredefinedPolicy"), 
         OutputType(typeof(PSApplicationGatewaySslPredefinedPolicy), typeof(IEnumerable<PSApplicationGatewaySslPredefinedPolicy>))]
-    [Alias("Get-AzureRmApplicationGatewaySslPredefinedPolicy")]
+    [Alias("List-AzureRmApplicationGatewaySslPredefinedPolicy")]
     public class GetAzureApplicationGatewaySslPredefinedPolicy : ApplicationGatewayBaseCmdlet
     {
         [Parameter(

src/ResourceManager/Network/Commands.Network/ApplicationGateway/NewAzureApplicationGatewayCommand.cs

@@ -130,7 +130,7 @@ public class NewAzureApplicationGatewayCommand : ApplicationGatewayBaseCmdlet
         public List<PSApplicationGatewayRequestRoutingRule> RequestRoutingRules { get; set; }
 
         [Parameter(
-             Mandatory = true,
+             Mandatory = false,
              ValueFromPipelineByPropertyName = true,
              HelpMessage = "The list of redirect configuration")]
         public List<PSApplicationGatewayRedirectConfiguration> RedirectConfigurations { get; set; }

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

@@ -175,8 +175,8 @@
     <Compile Include="ApplicationGateway\FirewallConfiguration\GetAzureApplicationGatewayWebApplicationFirewallConfigurationCommand.cs" />
     <Compile Include="ApplicationGateway\FirewallConfiguration\NewAzureApplicationGatewayWebApplicationFirewallConfigurationCommand.cs" />
     <Compile Include="ApplicationGateway\FirewallConfiguration\SetAzureApplicationGatewayWebApplicationFirewallConfigurationCommand.cs" />
-    <Compile Include="ApplicationGateway\GetAzureApplicationGatewaySslPredefinedPolicy.cs" />
     <Compile Include="ApplicationGateway\GetAzureApplicationGatewayAvailableSslOptions.cs" />
+    <Compile Include="ApplicationGateway\ListAzureApplicationGatewaySslPredefinedPolicy.cs" />
     <Compile Include="ApplicationGateway\ProbeHealthResponseMatch\AzureApplicationGatewayProbeHealthResponseMatchBase.cs" />
     <Compile Include="ApplicationGateway\ProbeHealthResponseMatch\NewAzureApplicationGatewayProbeHealthResponseMatchCommand.cs" />
     <Compile Include="ApplicationGateway\FrontendIPConfiguration\AddAzureApplicationGatewayFrontendIPConfigCommand.cs" />