Skip to content

Conversation

@julien-c
Copy link
Member

@julien-c julien-c commented Mar 19, 2020

Also, #3305 breaks (if i'm not mistaken) the ability to run the example script from a pip-installed instance of transformers (vs. from an instance installed from source) (This PR does not fix that second issue)

@julien-c julien-c requested review from LysandreJik and srush March 19, 2020 02:11
@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #3335 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3335      +/-   ##
==========================================
- Coverage   77.63%   77.57%   -0.07%     
==========================================
  Files         100      100              
  Lines       16943    16943              
==========================================
- Hits        13154    13143      -11     
- Misses       3789     3800      +11
Impacted Files Coverage Δ
src/transformers/modeling_tf_utils.py 86.4% <0%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20139b7...7fc00b6. Read the comment docs.

@julien-c
Copy link
Member Author

Ok I'll merge this @srush @LysandreJik as it's more correct (feel free to let me know of your feedback anyways)

@julien-c julien-c merged commit 656e138 into master Mar 19, 2020
@julien-c julien-c deleted the fix_pr_3305 branch March 19, 2020 20:41
@srush
Copy link
Contributor

srush commented Mar 19, 2020

Thanks. Why does it break the pip version?

@julien-c
Copy link
Member Author

Because MODEL_MAPPING from modeling_auto is not exposed in the package's __init__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants