From 901ffef7c6597ae6839718fdcd4530e0862f3681 Mon Sep 17 00:00:00 2001 From: Jake Bassett Date: Tue, 15 Feb 2022 14:45:12 -0800 Subject: [PATCH 1/2] fix: improve query error console messaging --- .../graphql-client/src/graphql-request.service.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/projects/graphql-client/src/graphql-request.service.ts b/projects/graphql-client/src/graphql-request.service.ts index 4c97ccf10..e6a49a0dd 100644 --- a/projects/graphql-client/src/graphql-request.service.ts +++ b/projects/graphql-client/src/graphql-request.service.ts @@ -1,8 +1,8 @@ import { Inject, Injectable } from '@angular/core'; import { Apollo, gql } from 'apollo-angular'; -import { includes, uniq } from 'lodash-es'; +import { includes, isNil, uniq } from 'lodash-es'; import { defer, EMPTY, Observable, Observer, of, Subject, zip } from 'rxjs'; -import { buffer, catchError, debounceTime, filter, map, mergeMap, take } from 'rxjs/operators'; +import { buffer, catchError, debounceTime, filter, map, mergeMap, take, tap } from 'rxjs/operators'; import { GraphQlHandler, GraphQlHandlerType, @@ -151,7 +151,15 @@ export class GraphQlRequestService { errorPolicy: 'all', fetchPolicy: options.cacheability }) - .pipe(map(response => response.data)); + .pipe( + tap(response => { + if (!isNil(response.errors)) { + // tslint:disable-next-line: no-console + console.error(`Query response error(s) for request '${requestString}'`, response.errors); + } + }), + map(response => response.data) + ); } private executeMutation(requestString: string): Observable { From f13b62ce021e93d76468e96158cbf4a067260d8a Mon Sep 17 00:00:00 2001 From: Jake Bassett Date: Tue, 15 Feb 2022 15:25:47 -0800 Subject: [PATCH 2/2] fix: add mutation message as well --- projects/graphql-client/src/graphql-request.service.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/projects/graphql-client/src/graphql-request.service.ts b/projects/graphql-client/src/graphql-request.service.ts index e6a49a0dd..de7a68655 100644 --- a/projects/graphql-client/src/graphql-request.service.ts +++ b/projects/graphql-client/src/graphql-request.service.ts @@ -167,7 +167,15 @@ export class GraphQlRequestService { .mutate({ mutation: gql(`mutation ${requestString}`) }) - .pipe(mergeMap(response => (response.data ? of(response.data) : EMPTY))); + .pipe( + tap(response => { + if (!isNil(response.errors)) { + // tslint:disable-next-line: no-console + console.error(`Mutation response error(s) for request '${requestString}'`, response.errors); + } + }), + mergeMap(response => (response.data ? of(response.data) : EMPTY)) + ); } private getResultForRequest(request: GraphQlRequest): Observable {