diff --git a/projects/observability/src/pages/apis/api-detail/traces/api-trace-list.dashboard.ts b/projects/observability/src/pages/apis/api-detail/traces/api-trace-list.dashboard.ts index e125d7ae0..7c8d0dc4f 100644 --- a/projects/observability/src/pages/apis/api-detail/traces/api-trace-list.dashboard.ts +++ b/projects/observability/src/pages/apis/api-detail/traces/api-trace-list.dashboard.ts @@ -25,7 +25,7 @@ export const apiTraceListDashboard = { { type: 'table-widget-column', title: 'Exit Calls', - filterable: true, + filterable: false, display: ObservabilityTableCellType.ExitCalls, value: { type: 'composite-specification', diff --git a/projects/observability/src/pages/apis/service-detail/traces/service-trace-list.dashboard.ts b/projects/observability/src/pages/apis/service-detail/traces/service-trace-list.dashboard.ts index b7621cdd5..c7a4e7c60 100644 --- a/projects/observability/src/pages/apis/service-detail/traces/service-trace-list.dashboard.ts +++ b/projects/observability/src/pages/apis/service-detail/traces/service-trace-list.dashboard.ts @@ -51,7 +51,7 @@ export const serviceTraceListDashboard = { { type: 'table-widget-column', title: 'Exit Calls', - filterable: true, + filterable: false, display: ObservabilityTableCellType.ExitCalls, value: { type: 'composite-specification', diff --git a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.scss b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.scss index 5f7075ee5..8e0ae1510 100644 --- a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.scss +++ b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.scss @@ -5,7 +5,7 @@ @include body-1-regular($gray-7); } -.api-callee-name-count { +.api-callee-name-entries { @include body-small($gray-3); display: flex; align-items: center; diff --git a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.test.ts b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.test.ts index a18c75e68..8c9ccea20 100644 --- a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.test.ts +++ b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.test.ts @@ -33,11 +33,11 @@ describe('Exit Calls table cell renderer component', () => { }); expect(spectator.queryAll('.exit-calls-count')[0]).toContainText('3'); - expect(spectator.component.apiCalleeNameCount).toMatchObject([ + expect(spectator.component.apiCalleeNameEntries).toMatchObject([ ['key1', '1'], ['key2', '2'] ]); - expect(spectator.component.totalCountOfDifferentApiCallee).toBe(2); + expect(spectator.component.uniqueApiCalleeCount).toBe(2); expect(spectator.component.apiExitCalls).toBe(3); }); }); diff --git a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.ts b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.ts index 374424dcc..1313315c7 100644 --- a/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.ts +++ b/projects/observability/src/shared/components/table/data-cell/exit-calls/exit-calls-table-cell-renderer.component.ts @@ -29,19 +29,19 @@ interface CellData { {{ this.apiExitCalls }} - -
+ +
{{ item[0] }} {{ item[1] }}
- and {{ this.totalCountOfDifferentApiCallee - this.maxShowApiCalleeNameCount }} more + and {{ this.uniqueApiCalleeCount - ${ExitCallsTableCellRendererComponent.MAX_API_CALLEES_TO_SHOW} }} more
- No exit calls + No exit calls
` @@ -52,10 +52,10 @@ interface CellData { parser: CoreTableCellParserType.NoOp }) export class ExitCallsTableCellRendererComponent extends TableCellRendererBase implements OnInit { - public readonly apiCalleeNameCount: string[][]; + public static readonly MAX_API_CALLEES_TO_SHOW: number = 10; + public readonly apiCalleeNameEntries: [string, string][]; public readonly apiExitCalls: number; - public readonly maxShowApiCalleeNameCount: number = 10; - public readonly totalCountOfDifferentApiCallee!: number; + public readonly uniqueApiCalleeCount: number; public constructor( @Inject(TABLE_COLUMN_CONFIG) columnConfig: TableColumnConfig, @@ -66,9 +66,12 @@ export class ExitCallsTableCellRendererComponent extends TableCellRendererBase