Merge pull request #193 from vsaase/lossless

Lossless JPEG decoding

Author: HeroicKatora

.github/workflows/rust.yml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        rust: ["1.34.2", stable, beta, nightly]
+        rust: ["1.36.0", stable, beta, nightly]
         features: ["", "rayon"]
         command: [test, benchmark]
 
@@ -29,11 +29,11 @@ jobs:
       - name: test
         run: >
           cargo test --tests --benches --no-default-features --features "$FEATURES"
-        if: ${{ matrix.command == 'test' && matrix.rust != '1.34.2' }}
+        if: ${{ matrix.command == 'test' && matrix.rust != '1.36.0' }}
         env:
           FEATURES: ${{ matrix.features }}
       - name: benchmark
         run: cargo bench --bench decoding_benchmark --no-default-features --features "$FEATURES" -- --warm-up-time 1 --measurement-time 1 --sample-size 25
-        if: ${{ matrix.command == 'benchmark' && matrix.rust != '1.34.2' }}
+        if: ${{ matrix.command == 'benchmark' && matrix.rust != '1.36.0' }}
         env:
           FEATURES: ${{ matrix.features }}

CHANGELOG.md

@@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+- Added Lossless JPEG support
+- Minimum supported rust version changed to 1.36
+
 ## v0.1.22 (2021-01-27)
 
 - Fix panic on jpeg without frames.

README.md

@@ -32,4 +32,4 @@ fn main() {
 ```
 
 ## Requirements
-This crate compiles only with rust >= 1.34.
+This crate compiles only with rust >= 1.36.

benches/decoding_benchmark.rs

@@ -33,5 +33,9 @@ fn main() {
     c.bench_function("extract metadata from an image", |b| b.iter(|| {
         read_metadata(include_bytes!("tower.jpg"))
     }));
+    
+    c.bench_function("decode a 3072x2048 RGB Lossless JPEG", |b| b.iter(|| {
+        read_image(include_bytes!("../tests/reftest/images/lossless/jpeg_lossless_sel1-rgb.jpg"))
+    }));
     c.final_summary();
 }

examples/decode.rs

@@ -23,17 +23,27 @@ fn main() {
 
     let output_file = File::create(output_path).unwrap();
     let mut encoder = png::Encoder::new(output_file, info.width as u32, info.height as u32);
-    encoder.set_depth(png::BitDepth::Eight);
 
     match info.pixel_format {
-        jpeg::PixelFormat::L8     => encoder.set_color(png::ColorType::Grayscale),
-        jpeg::PixelFormat::RGB24  => encoder.set_color(png::ColorType::RGB),
+        jpeg::PixelFormat::L16 => {
+            encoder.set_depth(png::BitDepth::Sixteen);
+            encoder.set_color(png::ColorType::Grayscale);
+        },
+        jpeg::PixelFormat::RGB24  => {
+            encoder.set_depth(png::BitDepth::Eight);
+            encoder.set_color(png::ColorType::RGB);
+        },
         jpeg::PixelFormat::CMYK32 => {
             data = cmyk_to_rgb(&mut data);
+            encoder.set_depth(png::BitDepth::Eight);
             encoder.set_color(png::ColorType::RGB)
         },
-    };
-
+        jpeg::PixelFormat::L8 => {
+            encoder.set_depth(png::BitDepth::Eight);
+            encoder.set_color(png::ColorType::Grayscale);
+        },
+    }
+    
     encoder.write_header()
            .expect("writing png header failed")
            .write_image_data(&data)

rust-toolchain

@@ -1 +1 @@
-1.34.2
+1.36

src/decoder.rs

@@ -15,6 +15,9 @@ use worker::{RowData, PlatformWorker, Worker};
 
 pub const MAX_COMPONENTS: usize = 4;
 
+mod lossless;
+use self::lossless::compute_image_lossless;
+
 static UNZIGZAG: [u8; 64] = [
      0,  1,  8, 16,  9,  2,  3, 10,
     17, 24, 32, 25, 18, 11,  4,  5,
@@ -31,6 +34,8 @@ static UNZIGZAG: [u8; 64] = [
 pub enum PixelFormat {
     /// Luminance (grayscale), 8 bits
     L8,
+    /// Luminance (grayscale), 16 bits
+    L16,
     /// RGB, 8 bits per channel
     RGB24,
     /// CMYK, 8 bits per channel
@@ -42,6 +47,7 @@ impl PixelFormat {
     pub fn pixel_bytes(&self) -> usize {
         match self {
             PixelFormat::L8 => 1,
+            PixelFormat::L16 => 2,
             PixelFormat::RGB24 => 3,
             PixelFormat::CMYK32 => 4,
         }
@@ -57,6 +63,8 @@ pub struct ImageInfo {
     pub height: u16,
     /// The pixel format of the image.
     pub pixel_format: PixelFormat,
+    /// The coding process of the image.
+    pub coding_process: CodingProcess,
 }
 
 /// JPEG decoder
@@ -111,7 +119,11 @@ impl<R: Read> Decoder<R> {
         match self.frame {
             Some(ref frame) => {
                 let pixel_format = match frame.components.len() {
-                    1 => PixelFormat::L8,
+                    1 => match frame.precision {
+                        8 => PixelFormat::L8,
+                        16 => PixelFormat::L16,
+                        _ => panic!()
+                    },
                     3 => PixelFormat::RGB24,
                     4 => PixelFormat::CMYK32,
                     _ => panic!(),
@@ -121,6 +133,7 @@ impl<R: Read> Decoder<R> {
                     width: frame.output_size.width,
                     height: frame.output_size.height,
                     pixel_format: pixel_format,
+                    coding_process: frame.coding_process,
                 })
             },
             None => None,
@@ -209,7 +222,8 @@ impl<R: Read> Decoder<R> {
         let mut pending_marker = None;
         let mut worker = None;
         let mut scans_processed = 0;
-        let mut planes = vec![Vec::new(); self.frame.as_ref().map_or(0, |frame| frame.components.len())];
+        let mut planes = vec![Vec::<u8>::new(); self.frame.as_ref().map_or(0, |frame| frame.components.len())];
+        let mut planes_u16 = vec![Vec::<u16>::new(); self.frame.as_ref().map_or(0, |frame| frame.components.len())];
 
         loop {
             let marker = match pending_marker.take() {
@@ -234,13 +248,13 @@ impl<R: Read> Decoder<R> {
                     if frame.is_differential {
                         return Err(Error::Unsupported(UnsupportedFeature::Hierarchical));
                     }
-                    if frame.coding_process == CodingProcess::Lossless {
-                        return Err(Error::Unsupported(UnsupportedFeature::Lossless));
-                    }
                     if frame.entropy_coding == EntropyCoding::Arithmetic {
                         return Err(Error::Unsupported(UnsupportedFeature::ArithmeticEntropyCoding));
                     }
-                    if frame.precision != 8 {
+                    if frame.precision != 8 && frame.coding_process != CodingProcess::Lossless {
+                        return Err(Error::Unsupported(UnsupportedFeature::SamplePrecision(frame.precision)));
+                    }
+                    if frame.precision != 8 && frame.precision != 16 {
                         return Err(Error::Unsupported(UnsupportedFeature::SamplePrecision(frame.precision)));
                     }
                     if component_count != 1 && component_count != 3 && component_count != 4 {
@@ -257,6 +271,7 @@ impl<R: Read> Decoder<R> {
                     }
 
                     planes = vec![Vec::new(); component_count];
+                    planes_u16 = vec![Vec::new(); component_count];
                 },
 
                 // Scan header
@@ -278,46 +293,57 @@ impl<R: Read> Decoder<R> {
                         }).collect();
                     }
 
-                    // This was previously buggy, so let's explain the log here a bit. When a
-                    // progressive frame is encoded then the coefficients (DC, AC) of each
-                    // component (=color plane) can be split amongst scans. In particular it can
-                    // happen or at least occurs in the wild that a scan contains coefficient 0 of
-                    // all components. If now one but not all components had all other coefficients
-                    // delivered in previous scans then such a scan contains all components but
-                    // completes only some of them! (This is technically NOT permitted for all
-                    // other coefficients as the standard dictates that scans with coefficients
-                    // other than the 0th must only contain ONE component so we would either
-                    // complete it or not. We may want to detect and error in case more component
-                    // are part of a scan than allowed.) What a weird edge case.
-                    //
-                    // But this means we track precisely which components get completed here.
-                    let mut finished = [false; MAX_COMPONENTS];
-
-                    if scan.successive_approximation_low == 0 {
-                        for (&i, component_finished) in scan.component_indices.iter().zip(&mut finished) {
-                            if self.coefficients_finished[i] == !0 {
-                                continue;
-                            }
-                            for j in scan.spectral_selection.clone() {
-                                self.coefficients_finished[i] |= 1 << j;
-                            }
-                            if self.coefficients_finished[i] == !0 {
-                                *component_finished = true;
-                            }
+                    
+                    if frame.coding_process == CodingProcess::Lossless {
+                        let (marker, data) = self.decode_scan_lossless(&frame, &scan)?;
+
+                        for (i, plane) in data.into_iter().enumerate().filter(|&(_, ref plane)| !plane.is_empty()) {
+                            planes_u16[i] = plane;
                         }
+                        pending_marker = marker;
                     }
+                    else {
+                        // This was previously buggy, so let's explain the log here a bit. When a
+                        // progressive frame is encoded then the coefficients (DC, AC) of each
+                        // component (=color plane) can be split amongst scans. In particular it can
+                        // happen or at least occurs in the wild that a scan contains coefficient 0 of
+                        // all components. If now one but not all components had all other coefficients
+                        // delivered in previous scans then such a scan contains all components but
+                        // completes only some of them! (This is technically NOT permitted for all
+                        // other coefficients as the standard dictates that scans with coefficients
+                        // other than the 0th must only contain ONE component so we would either
+                        // complete it or not. We may want to detect and error in case more component
+                        // are part of a scan than allowed.) What a weird edge case.
+                        //
+                        // But this means we track precisely which components get completed here.
+                        let mut finished = [false; MAX_COMPONENTS];
+
+                        if scan.successive_approximation_low == 0 {
+                            for (&i, component_finished) in scan.component_indices.iter().zip(&mut finished) {
+                                if self.coefficients_finished[i] == !0 {
+                                    continue;
+                                }
+                                for j in scan.spectral_selection.clone() {
+                                    self.coefficients_finished[i] |= 1 << j;
+                                }
+                                if self.coefficients_finished[i] == !0 {
+                                    *component_finished = true;
+                                }
+                            }
+                        }
 
-                    let (marker, data) = self.decode_scan(&frame, &scan, worker.as_mut().unwrap(), &finished)?;
+                        let (marker, data) = self.decode_scan(&frame, &scan, worker.as_mut().unwrap(), &finished)?;
 
-                    if let Some(data) = data {
-                        for (i, plane) in data.into_iter().enumerate().filter(|&(_, ref plane)| !plane.is_empty()) {
-                            if self.coefficients_finished[i] == !0 {
-                                planes[i] = plane;
+                        if let Some(data) = data {
+                            for (i, plane) in data.into_iter().enumerate().filter(|&(_, ref plane)| !plane.is_empty()) {
+                                if self.coefficients_finished[i] == !0 {
+                                    planes[i] = plane;
+                                }
                             }
                         }
+                        pending_marker = marker;
                     }
 
-                    pending_marker = marker;
                     scans_processed += 1;
                 },
 
@@ -465,7 +491,12 @@ impl<R: Read> Decoder<R> {
             }
         }
 
-        compute_image(&frame.components, planes, frame.output_size, self.is_jfif, self.color_transform)
+        if frame.coding_process == CodingProcess::Lossless {
+            compute_image_lossless(&frame, planes_u16)
+        }
+        else{
+            compute_image(&frame.components, planes, frame.output_size, self.is_jfif, self.color_transform)
+        }
     }
 
     fn read_marker(&mut self) -> Result<Marker> {
@@ -964,6 +995,7 @@ fn compute_image(components: &[Component],
     }
 }
 
+
 #[cfg(feature="rayon")]
 fn compute_image_parallel(components: &[Component],
                           data: Vec<Vec<u8>>,