Commit 80ef68e
selftests/bpf: Check ASSERT_OK(err) in dummy_st_ops
Run dummy_st_ops selftests (./test_progs -t dummy_st_ops) on a Loongarch
platform, some "unexpected arg" errors occur:
'''
torvalds#78/1 dummy_st_ops/dummy_st_ops_attach:OK
test_dummy_init_ret_value:FAIL:test_ret unexpected test_ret: \
actual 0 != expected 4076074229
torvalds#78/2 dummy_st_ops/dummy_init_ret_value:FAIL
torvalds#78/3 dummy_st_ops/dummy_init_ptr_arg:SKIP
test_dummy_multiple_args:FAIL:arg 0 unexpected arg 0: \
actual 0 != expected 7
test_dummy_multiple_args:FAIL:arg 1 unexpected arg 1: \
actual 0 != expected -100
test_dummy_multiple_args:FAIL:arg 2 unexpected arg 2: \
actual 0 != expected 35423
test_dummy_multiple_args:FAIL:arg 3 unexpected arg 3: \
actual 0 != expected 99
test_dummy_multiple_args:FAIL:arg 4 unexpected arg 4: \
actual 0 != expected 1311768467139281697
torvalds#78/4 dummy_st_ops/dummy_multiple_args:FAIL
torvalds#78/5 dummy_st_ops/dummy_sleepable:SKIP
torvalds#78/6 dummy_st_ops/dummy_sleepable_reject_null:OK
torvalds#78/7 dummy_st_ops/test_unsupported_field_sleepable:OK
torvalds#78 dummy_st_ops:FAIL
'''
This is because BPF trampoline is not implemented on Loongarch yet,
bpf_prog_test_run_opts() returns ENOTSUPP.
This patch checks the return values of bpf_prog_test_run_opts() in
dummy_st_ops to fix these errors. If error returned, goto the newly
added label "out" to destroy the skel.
Signed-off-by: Geliang Tang <[email protected]>1 parent 5a38451 commit 80ef68e
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
118 | | - | |
| 120 | + | |
| 121 | + | |
119 | 122 | | |
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
| 128 | + | |
125 | 129 | | |
126 | 130 | | |
127 | 131 | | |
| |||
0 commit comments