doc: fix format docs discrepancy #1255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this target the |
|
LGTM, but as pointed out, please change the commit subsystem to |
Only objects and symbols use `util.inspect`, others are simply concatenated. Fixes: nodejs#935
brendanashworth
force-pushed
the
fix-util-format-docs
branch
from
f237ecd to
a8fd9c4
Compare
brendanashworth
changed the title
|
Ah, yes, thank you, I missed that. It's now been fixed, merging in a short while. |
brendanashworth
added a commit
that referenced
this pull request
Mar 25, 2015
Only objects and symbols use `util.inspect`, others are simply concatenated. Fixes: #935 PR-URL: #1255 Reviewed-By: Colin Ihrig <[email protected]>
|
Thanks, this has been merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only objects and symbols use
util.inspect, others are simplyconcatenated.
Fixes: #935
R=@cjihrig?