V1.x android #1307
V1.x android #1307
Conversation
README.md
Outdated
There was a problem hiding this comment.
path/to/your/android-ndk?
There was a problem hiding this comment.
Yes, to compile for Android devices you need to use the toolchain in the Android NDK for cross compiling. Inside Android NDK there is an build/tools/make-standalone-toolchain.sh script that will create an android-toolchain folder inside io.js folder with the cross binaries to use.
There was a problem hiding this comment.
I think he was pointing out the typo? /you/ -> /your/
There was a problem hiding this comment.
Sorry, I should have made that more obvious :)
There was a problem hiding this comment.
Sorry, that has more sense now. I going to fix it. :)
|
Let me know if there's something that needs a change. If not I will squash the commits on this PR to merge it. |
|
@bnoordhuis it's done! Please, check it an let me know if everything is ok. |
README.md
Outdated
There was a problem hiding this comment.
can you remove the sh please, we're showing these shell examples without that formatting because it makes little sense and isn't consistent when you're not showing bash anyway (plus, $ isn't a bashism as it's used here)
|
@rvagg it's done |
|
lgtm with one question |
|
Answered question @rvagg |
Also add Android build instructions to the README. PR-URL: #1307 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks, landed with a reworded commit log in 65d4d25. I also backed out the ARMv6 changes FWIW. |
Notable changes: * npm: upgrade npm to 2.7.5. See the npm CHANGELOG.md for details. Includes two important security fixes. https://github.com/npm/npm/blob/master/CHANGELOG.md#v275-2015-03-26 * openssl: preliminary work has been done for an upcoming upgrade to OpenSSL 1.0.2a #1325 (Shigeki Ohtsu). See #589 for additional details. * timers: a minor memory leak when timers are unreferenced was fixed, alongside some related timers issues #1330 (Fedor Indutny). This appears to have fixed the remaining leak reported in #1075. * android: it is now possible to compile io.js for Android and related devices #1307 (Giovanny Andres Gongora Granada).
6 participants
Those are a few changes I did to compile io.js and run it as bin file on Android and based devices.