Skip to content

Fix behaviour on systems with alternative minus sign characters #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix behaviour on systems with alternative minus sign characters #8

wants to merge 2 commits into from

Conversation

evileye-uk
Copy link

Some tests would fail when negative signs other than hyphen-minus were set. These changes address that.

Evileye added 2 commits June 17, 2019 11:48
Fix unit tests failing with changed locale minus.
43d5c3a 
The behaviour was broken when the locale negative sign was changed
from '-' to other characters. This change updates behaviour so
that it passes those tests which were failing.
Fix setup of integration tests.
0d09b30 
Integration tests were failing when negative sign was
not the '-' character. This ensures the input files
are loaded correctly.
@BlackEgoist
Copy link
Contributor

BlackEgoist commented Jun 24, 2020 •
edited
Loading

Hi, @evileye-uk! Thank you for your contribution. The commits ec132a6 and ced792f were added manually to our development branch under your name.
We have also introduced the new class for stream formatting in .NET that will insure that InvariantCulture parameter is always used in such conversions. This change will fix the issues with failing tests on systems with alternative minus sign characters as well.
Your contribution suggestions are always welcome. The pull request will be closed soon.

@Snipx Snipx closed this Jun 24, 2020
@Snipx
Copy link
Contributor

Snipx commented Sep 1, 2020

Hi @evileye-uk, we tried to contact you regarding a small question at the email attached to your commit but we got an automatic reply that the domain does not exist. Would you mind sharing your email or emailing me at alexey[dot]subach[at]itextpdf[dot]com ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evileye-uk @BlackEgoist @Snipx